Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bundled version of PTVSD in debugger #3283

Closed
DonJayamanne opened this issue Nov 9, 2018 · 3 comments
Closed

Use bundled version of PTVSD in debugger #3283

DonJayamanne opened this issue Nov 9, 2018 · 3 comments
Labels
area-debugging feature-request Request for new features or functionality
Milestone
2018, week 48 - D...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Nov 9, 2018 •
edited
Loading

Today the debugger ends up using the version of PTSVD installed in the current environment (available in the current path) as opposed to using what's bundled in the extension.

We might want to ensure we always use the bundled version of PTVSD and allow users to configure whether to use bundled version or their own copy of PTVSD.
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality area-debugging needs decision labels Nov 9, 2018
This was referenced Nov 13, 2018
Closed
Closed
@brettcannon brettcannon added needs PR and removed P0 labels Nov 14, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Nov 21, 2018 •
edited by brettcannon
Loading

Suggestion:

  • Add a setting customDebugger into launch.json settings.
  • If this is initialized to true, then we use PTVSD that's in the current path. E.g. if PTVSD is installed in current python environment,
  • Else, we always use PTVSD that's bundled with the extension.

@DonJayamanne DonJayamanne changed the title Validate version of PTVSD installed Use bundled version of PTVSD in debugger Nov 21, 2018
@DonJayamanne DonJayamanne mentioned this issue Nov 22, 2018
Merged
5 tasks
@brettcannon brettcannon reopened this Dec 12, 2018
@DonJayamanne
Copy link
Author

Why had this been reopened?

@brettcannon
Copy link
Member

@DonJayamanne I don't remember seeing this go through the PM sign-off stage for the new flag.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
2018, week 48 - Dec sprint 1
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne