Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-run notebook setup code after kernel reset #3418

Merged
merged 1 commit into from
Nov 21, 2018
Merged

re-run notebook setup code after kernel reset #3418

merged 1 commit into from
Nov 21, 2018

Conversation

IanMatthewHuff
Copy link
Member

For #3366

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

rchiodo
rchiodo approved these changes Nov 20, 2018
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit 397ea8b into microsoft:master Nov 21, 2018
@IanMatthewHuff IanMatthewHuff mentioned this pull request Nov 21, 2018
Merged
6 tasks
@JackCaster
Copy link

Great that you fixed that. It is just a detail, but for a nice integration with the editor theme, please, consider setting the color of the axis transparent (the rcparam is axes.facecolor : none)

@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixPlotsOnRestart branch July 25, 2019 23:49
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@d3r3kk d3r3kk Awaiting requested review from d3r3kk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanMatthewHuff @JackCaster @rchiodo