Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename source maps and change how we enable/disable source maps #3905

Closed
DonJayamanne opened this issue Jan 7, 2019 · 1 comment
Closed

Rename source maps and change how we enable/disable source maps #3905

DonJayamanne opened this issue Jan 7, 2019 · 1 comment
Assignees
@karrtikr
Labels
feature-request Request for new features or functionality
Milestone
2019, week 3 - Ja...

Comments

@DonJayamanne
Copy link

VSC now loads source maps in extensions.
We need to rename the source maps files, else they get loaded by VSC automatically.
Solution - rename source maps to some other file name, when enabling rename back to *.js.map.

Not doing this results in extension taking over a full second to load the extension.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 7, 2019
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR labels Jan 7, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 7, 2019
@DonJayamanne DonJayamanne self-assigned this Jan 7, 2019
@DonJayamanne DonJayamanne mentioned this issue Jan 7, 2019
Merged
4 tasks
@DonJayamanne DonJayamanne removed this from the 2019, week 1 - Jan Sprint 1 milestone Jan 7, 2019
@d3r3kk d3r3kk added this to the 2019, week 3 - Jan Sprint 2 milestone Jan 17, 2019
DonJayamanne added a commit that referenced this issue Jan 18, 2019
@DonJayamanne
Changes to how source maps are enabled and disabled in the extension (#…
0f71b90 
…3906)

For #3905
@ericsnowcurrently
Copy link
Member

validated

@ghost ghost removed the needs PR label Jan 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
2019, week 3 - Jan Sprint 2
Development

No branches or pull requests
4 participants
@ericsnowcurrently @DonJayamanne @d3r3kk @karrtikr