Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site-packages in .venv directory aren't ignored by linter #3947

Closed
russelldavis opened this issue Jan 9, 2019 · 0 comments
Closed

site-packages in .venv directory aren't ignored by linter #3947

russelldavis opened this issue Jan 9, 2019 · 0 comments
Labels
area-linting bug Issue identified by VS Code Team member as probable bug

Comments

@russelldavis
Copy link

russelldavis commented Jan 9, 2019 •
edited
Loading

There's a default ignore pattern (**/site-packages/**/*.py) that's supposed to take of this, but it doesn't match files/dirs that start with a dot. This affects a lot of python projects (including this one -- Contributing.md recommends using that name), since .venv is a standard name for the virtualenv dir.

There's a simple fix (#3948)
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 9, 2019
@russelldavis russelldavis mentioned this issue Jan 9, 2019
Merged
6 tasks
@d3r3kk d3r3kk added the triage label Jan 10, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 10, 2019
@karrtikr karrtikr added area-linting bug Issue identified by VS Code Team member as probable bug and removed triage labels Jan 12, 2019
@karrtikr karrtikr removed their assignment Jan 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @russelldavis @d3r3kk @karrtikr