Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register language server onTelemetry when downloadLanguageServer is false #4199

Closed
jakebailey opened this issue Jan 29, 2019 · 0 comments
Closed

Don't register language server onTelemetry when downloadLanguageServer is false #4199

jakebailey opened this issue Jan 29, 2019 · 0 comments
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@jakebailey
Copy link
Member

#3974 removed a check which would prevent the telemetry event from being handled when python.downloadLanguageServer is false. This should be re-added so we aren't creating extra noise from our local builds.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 29, 2019
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority labels Jan 29, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 29, 2019
@jakebailey jakebailey mentioned this issue Feb 16, 2019
Closed
@brettcannon brettcannon added the area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. label Feb 19, 2019
@jakebailey jakebailey mentioned this issue Feb 19, 2019
Merged
8 tasks
@ghost ghost removed the needs PR label Feb 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @jakebailey @qubitron