Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use configuration api and provide Resource when retrieving settings #4486

Closed
DonJayamanne opened this issue Feb 21, 2019 · 1 comment
Closed

Use configuration api and provide Resource when retrieving settings #4486

DonJayamanne opened this issue Feb 21, 2019 · 1 comment
Assignees
@karrtikr
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2019, week 11 - M...

Comments

@DonJayamanne
Copy link

Fix warnings displayed on CI when running smoke tests:
screen shot 2019-02-21 at 11 25 14 am
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority labels Feb 21, 2019
@luabud luabud added bug Issue identified by VS Code Team member as probable bug and removed debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 12, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 13, 2019 •
edited
Loading

Solution:

  • Modify WorkspaceSpace to pass null as required (WorkspaceService class)
  • Modify other places where VSC API is used directly instead of using IWorkspaceService to either pass null or use the proper API (refactor and clean up) (around 20 instances)
  • If too completed to refactor, then pass null using native VSC API

@DonJayamanne DonJayamanne removed this from the 2019, week 11 - March Sprint 6 milestone Mar 13, 2019
@karrtikr karrtikr self-assigned this Mar 21, 2019
@karrtikr karrtikr mentioned this issue Mar 21, 2019
Merged
4 tasks
@ghost ghost removed the needs PR label Mar 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 11 - March Sprint 6
Development

No branches or pull requests
4 participants
@DonJayamanne @karrtikr @qubitron @luabud