Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor telemetry code #4602

Closed
DonJayamanne opened this issue Feb 28, 2019 · 2 comments
Closed

Refactor telemetry code #4602

DonJayamanne opened this issue Feb 28, 2019 · 2 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

When there's an error just send:

  • Original event
  • Error location
  • Drop other data items
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 28, 2019
@DonJayamanne DonJayamanne self-assigned this Feb 28, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 13, 2019

Prescribed Solution:

    if (ex && (eventName as any) !== 'ERROR') {
        customProperties.originalEventName = eventName as any as string;
        const data = { stackTrace: customProperties.stackTrace, originalEventName: eventName };
        reporter.sendTelemetryEvent('ERROR', data, measures);
    }

@DonJayamanne DonJayamanne removed this from the 2019, week 11 - March Sprint 6 milestone Mar 13, 2019
@luabud luabud added P0 important Issue identified as high-priority and removed P0 labels May 28, 2019
@DonJayamanne DonJayamanne removed their assignment May 29, 2019
@DonJayamanne DonJayamanne added this to the 2019 - May Sprint 11 milestone May 29, 2019
@DonJayamanne DonJayamanne self-assigned this May 30, 2019
@ericsnowcurrently
Copy link
Member

@DonJayamanne, how to validate this?

@ghost ghost removed the needs PR label Jun 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants