Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create package.json file to resolve some LS issues #5043

Closed
DonJayamanne opened this issue Apr 1, 2019 · 2 comments
Closed

Create package.json file to resolve some LS issues #5043

DonJayamanne opened this issue Apr 1, 2019 · 2 comments
Assignees
@DonJayamanne @karrtikr
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. important Issue identified as high-priority
Milestone
2019, week 15 - A...

Comments

@DonJayamanne
Copy link

No description provided.

@DonJayamanne DonJayamanne added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR important Issue identified as high-priority labels Apr 1, 2019
@DonJayamanne
Copy link
Author

Solution:

{
  "runtimeOptions": {
    "configProperties": {
      "System.Globalization.Invariant": true
    }
  }
}

@DonJayamanne DonJayamanne self-assigned this Apr 10, 2019
This was referenced Apr 11, 2019
Merged
Closed
DonJayamanne added a commit that referenced this issue Apr 15, 2019
@DonJayamanne
Ensure Language Server can start without ICU (#5196)
075d574 
For #5043
@karrtikr
Copy link

validated

@ghost ghost removed the needs PR label Apr 16, 2019
DonJayamanne added a commit that referenced this issue Apr 23, 2019
@DonJayamanne
Fixes to creation of json for Language Server (#5436)
e7a65cd 
For #5043

<!--
  If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
    - [x] ~Has unit tests & system/integration tests~
-->
- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
- [x] Title summarizes what is changing
- [n/a] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
- [n/a] Has sufficient logging.
- [n/a] Has telemetry for enhancements.
- [x] Unit tests & system/integration tests are added/updated
- [n/a] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
- [n/a] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
- [n/a] The wiki is updated with any design decisions/details.
@lock lock bot locked as resolved and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@karrtikr karrtikr

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 15 - April Sprint 8
Development

No branches or pull requests
3 participants
@ericsnowcurrently @DonJayamanne @karrtikr