Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade isort #5059

Closed
brettcannon opened this issue Apr 1, 2019 · 2 comments
Closed

Upgrade isort #5059

brettcannon opened this issue Apr 1, 2019 · 2 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Milestone
2019, week 15 - A...

Comments

@brettcannon
Copy link
Member

We are using 4.3.4 but [isort[(https://pypi.org/project/isort/) 4.3.16 is the latest. Might help with #2435 .
@brettcannon brettcannon added feature-refactoring debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 1, 2019
@DonJayamanne
Copy link

  • Update requirements.txt
  • Wait for CI to pass
  • Manual test

@DonJayamanne DonJayamanne self-assigned this Apr 10, 2019
@DonJayamanne DonJayamanne mentioned this issue Apr 11, 2019
Merged
3 tasks
@ericsnowcurrently ericsnowcurrently removed their assignment Apr 16, 2019
@ericsnowcurrently
Copy link
Member

I've verified that the "Python Refactor: Sort Imports" command works with the insiders VSIX from last night.

@ghost ghost removed the needs PR label Apr 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
2019, week 15 - April Sprint 8
Development

No branches or pull requests
4 participants
@brettcannon @ericsnowcurrently @DonJayamanne @karrtikr