Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry for the usage of Poetry #5063

Closed
4 tasks done
luabud opened this issue Apr 1, 2019 · 0 comments
Closed
4 tasks done

Add telemetry for the usage of Poetry #5063

luabud opened this issue Apr 1, 2019 · 0 comments
Assignees
@DonJayamanne
Labels
good first issue important Issue identified as high-priority
Milestone
2019, week 13 - M...

Comments

@luabud
Copy link
Member

luabud commented Apr 1, 2019 •
edited by DonJayamanne
Loading

Add telemetry to track the installation channel for python packages:

  • Pip
  • Poetry
  • Conda
  • PipEnv

Prescribed Solution

  • Modify the installModule method of moduleInstaller.ts
  • In the above installModule method access the name of the installer (pip, poetry, pipenv, conda, etc) from the displayName property
    • Send the above name via telemetry

Note:

  • The above property displayName contains a string that is hardcoded
  • I.e. this property does not contain any PII.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Apr 1, 2019
@DonJayamanne DonJayamanne changed the title Add telemetry for Poetry Add telemetry for the usage of Poetry Apr 1, 2019
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label Apr 1, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 1, 2019
@DonJayamanne DonJayamanne added needs PR triage-needed Needs assignment to the proper sub-team labels Apr 1, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 1, 2019
@DonJayamanne DonJayamanne self-assigned this Apr 3, 2019
@ghost ghost removed the needs PR label Apr 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
good first issue important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 13 - March Sprint 7
Development

No branches or pull requests
2 participants
@DonJayamanne @luabud