Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreVsCodeTheme setting isn't working anymore #3431

Closed
rchiodo opened this issue Apr 25, 2019 · 10 comments
Closed

ignoreVsCodeTheme setting isn't working anymore #3431

rchiodo opened this issue Apr 25, 2019 · 10 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Apr 25, 2019

IgnoreVSCodeTheme should force the python interactive window to always be white.

It's not working.

@stevenlis
Copy link

In the meantime, a workaround for the global setting:

sns.set_style(rc={'figure.facecolor':'white'})

image

@rchiodo rchiodo self-assigned this Apr 25, 2019
@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 25, 2019

Sorry about that. Ignorevscode theme will be fixed in our next insider's build

@stevenlis
Copy link

It seems like currently set ignoreVsCodeTheme to true will also affect the color of the code in the interactive windows. Is this expected?

@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 25, 2019

Yes that's the intent. It should behave entirely like you have the default theme selected.

It's busted in the current release, but the insider's build should fix it that way.

Here's a screenshot of it working:
image

@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 25, 2019

The release bits are only sort of working, not sure if that's what you were referring to or not.

@stevenlis
Copy link

oh...ok.I thought it just makes the plots white like the style of the plot you will get by default in the Jupyter while keeping everything match the dark theme you're using.

@vlsd
Copy link

vlsd commented May 2, 2019

@StevenLi-DS how did you get the facecolor to be white rather than transparent? It seems like the default is full transparency, but I don't know what/where the setting for the alpha is.

@stevenlis
Copy link

I just used a seaborn function like shown in the screenshot above. If it doesn't work, take a look at the following issue:
https://github.com/Microsoft/vscode-python/issues/3773

@vlsd
Copy link

vlsd commented May 2, 2019

I just used a seaborn function like shown in the screenshot above. If it doesn't work, take a look at the following issue:
microsoft/vscode-python#3773

Huh, I did exactly that, but the facecolor for my figure is still transparent. I wonder if there's another setting somewhere that I'm missing. What backend are you using for matplotlib?

@vlsd
Copy link

vlsd commented May 2, 2019

Never mind, I was running some line magic that apparently was overriding that particular setting. Thanks for your quick response!

@rchiodo rchiodo closed this as completed Aug 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants