Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to analysisOptions.ts #5579

Closed
DonJayamanne opened this issue May 7, 2019 · 1 comment
Closed

Changes to analysisOptions.ts #5579

DonJayamanne opened this issue May 7, 2019 · 1 comment
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug good first issue important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

See here microsoft/python-language-server#1054 (comment)

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label May 7, 2019
@jakebailey
Copy link
Member

At the top, it's:

this.envPythonPath = vars.PYTHONPATH || '';

But at the bottom, it's:

const envPythonPath = vars.PYTHONPATH;

if (this.envPythonPath !== envPythonPath) {
    this.didChange.fire();
}

So if vars.PYTHONPATH is undefined, then this.envPythonPath will be '', but envPythonPath will be undefined (hence why I think it's always firing).

@DonJayamanne DonJayamanne added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR important Issue identified as high-priority bug Issue identified by VS Code Team member as probable bug labels May 7, 2019
@ghost ghost removed triage-needed Needs assignment to the proper sub-team labels May 7, 2019
@DonJayamanne DonJayamanne added triage-needed Needs assignment to the proper sub-team good first issue labels May 7, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 7, 2019
@DonJayamanne DonJayamanne added this to the 2019 - May Sprint 10 milestone May 9, 2019
@karrtikr karrtikr self-assigned this May 10, 2019
@ghost ghost removed the needs PR label May 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug good first issue important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants