Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around VSC issue with formatting on save #624

Closed
MikhailArkhipov opened this issue Jan 24, 2018 · 2 comments · Fixed by #635
Closed

Work around VSC issue with formatting on save #624

MikhailArkhipov opened this issue Jan 24, 2018 · 2 comments · Fixed by #635
Assignees
@MikhailArkhipov
Labels
area-formatting
Milestone
January 2018

Comments

@MikhailArkhipov
Copy link

MikhailArkhipov commented Jan 24, 2018 •
edited
Loading

microsoft/vscode#41194

Plan:

  • Save buffer content on formatting
  • if edits were created, remember that we've formatted
  • upon 'file saved' event check if edits were actually applied
  • if not, then execute 'format document' command and save the file
  • document workaround in release notes
  • remove it when upstream issue is saved.

Addresses
#590
#124
#492
@MikhailArkhipov MikhailArkhipov self-assigned this Jan 24, 2018
@MikhailArkhipov MikhailArkhipov added this to the January 2018 milestone Jan 24, 2018
@MikhailArkhipov MikhailArkhipov mentioned this issue Jan 25, 2018
Merged
MikhailArkhipov pushed a commit that referenced this issue Jan 29, 2018
Work around VSC issue with formatting on save #624 (#635)
94cd778 
* Basic tokenizer

* Fixed property names

* Tests, round I

* Tests, round II

* tokenizer test

* Remove temorary change

* Fix merge issue

* Merge conflict

* Merge conflict

* Completion test

* Fix last line

* Fix javascript math

* Make test await for results

* Add license headers

* Rename definitions to types

* License headers

* Fix typo in completion details (typo)

* Fix hover test

* Russian translations

* Update to better translation

* Fix typo

*  #70 How to get all parameter info when filling in a function param list

* Fix #70 How to get all parameter info when filling in a function param list

* Clean up

* Clean imports

* CR feedback

* Trim whitespace for test stability

* More tests

* Better handle no-parameters documentation

* Better handle ellipsis and Python3

* #385 Auto-Indentation doesn't work after comment

* #141 Auto indentation broken when return keyword involved

* Undo changes

* Round I

* Round 2

* Round 3

* Round 4

* Round 5

* no message

* Round 6

* Round 7

* Clean up targets and messages

* Settings propagation

* Tests

* Test warning

* Fix installer tests

* Tests

* Test fixes

* Fix terminal service and tests async/await

* Fix mock setup

* Test fix

* Test async/await fix

* Test fix + activate tslint on awaits

* Use command manager

* Work around updateSettings

* Multiroot fixes, partial

* More workarounds

* Multiroot tests

* Fix installer test

* Test fixes

* Disable prospector

* Enable dispose in all cases

* Fix event firing

* Min pylint options

* Min checkers & pylintrc discovery

* Fix Windows path in tests for Travis

* Fix Mac test

* Test fix

* Work around VSC issue with formatting on save #624

* Workaround test

* Unused

* Old file

* Use version instead of content

* Update tests
@MikhailArkhipov
Copy link
Author

94cd778

@MikhailArkhipov
Copy link
Author

94cd778

@brettcannon brettcannon mentioned this issue Jan 30, 2018
Closed
38 tasks
MikhailArkhipov pushed a commit that referenced this issue Feb 1, 2018
Formatting on Enter (#649)
b45aae3 
* Basic tokenizer

* Fixed property names

* Tests, round I

* Tests, round II

* tokenizer test

* Remove temorary change

* Fix merge issue

* Merge conflict

* Merge conflict

* Completion test

* Fix last line

* Fix javascript math

* Make test await for results

* Add license headers

* Rename definitions to types

* License headers

* Fix typo in completion details (typo)

* Fix hover test

* Russian translations

* Update to better translation

* Fix typo

*  #70 How to get all parameter info when filling in a function param list

* Fix #70 How to get all parameter info when filling in a function param list

* Clean up

* Clean imports

* CR feedback

* Trim whitespace for test stability

* More tests

* Better handle no-parameters documentation

* Better handle ellipsis and Python3

* #385 Auto-Indentation doesn't work after comment

* #141 Auto indentation broken when return keyword involved

* Undo changes

* On type formatting

* Fix warnings

* Round I

* Round 2

* Round 3

* Round 4

* Round 5

* no message

* Round 6

* Round 7

* Clean up targets and messages

* Settings propagation

* Tests

* Test warning

* Fix installer tests

* Tests

* Test fixes

* Fix terminal service and tests async/await

* Fix mock setup

* Test fix

* Test async/await fix

* Test fix + activate tslint on awaits

* Use command manager

* Work around updateSettings

* Multiroot fixes, partial

* More workarounds

* Multiroot tests

* Fix installer test

* Test fixes

* Disable prospector

* Enable dispose in all cases

* Fix event firing

* Min pylint options

* Min checkers & pylintrc discovery

* Fix Windows path in tests for Travis

* Fix Mac test

* Test fix

* Work around VSC issue with formatting on save #624

* Workaround test

* Unused

* Old file

* Brace and colon handling

* More tests

* Don't format inside strings and comments

* Provider tests

* Remove duplicate code
@MikhailArkhipov MikhailArkhipov mentioned this issue Apr 6, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-formatting
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Work around VSC issue with formatting on save #624
3 participants
@brettcannon @DonJayamanne @MikhailArkhipov