Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running multiple cells should stop on error #3302

Closed
rchiodo opened this issue Jun 27, 2019 · 3 comments
Closed

Running multiple cells should stop on error #3302

rchiodo opened this issue Jun 27, 2019 · 3 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 27, 2019

Came from a usability study

Perhaps with a flag to override

@ronglums
Copy link

By default run stops on the first error. Add a message "n cells are skipped due to the previous error. Use setting datascience.StopOnError to change the behavior." in the output if there're cells canceled due to error in the previous cell. The cells following the error cell will be removed in the interactive window.

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 11, 2019

This is likely going to require changes to how we submit as all of the cells have already been submitted to jupyter. Although the pendingCellSubscriptions could be used on an error to cancel all (but Jupyter might get to them first).

@rchiodo rchiodo self-assigned this Jul 11, 2019
@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 11, 2019

Preliminary bits in branch
rchiodo/stop_on_error

@rchiodo rchiodo assigned rchiodo and unassigned rchiodo Jul 11, 2019
@rchiodo rchiodo closed this as completed Aug 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants