Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On notebook import, line magics are rewritten without importing get_ipython() #3273

Closed
joyceerhl opened this issue Jul 14, 2019 · 0 comments
Closed

On notebook import, line magics are rewritten without importing get_ipython() #3273

joyceerhl opened this issue Jul 14, 2019 · 0 comments
Assignees
@joyceerhl

Comments

@joyceerhl
Copy link
Contributor

Expected behaviour

When a user imports an existing .ipynb file, IPython magics such as %matplotlib inline are converted to get_ipython().run_line_magic('matplotlib', 'inline'). There should be a corresponding from IPython import get_ipython import statement.

Actual behaviour

We do not currently add a from IPython import get_ipython cell on import, so the linter complains about get_ipython() being an undefined variable.
@joyceerhl joyceerhl self-assigned this Jul 14, 2019
@rchiodo rchiodo closed this as completed Jul 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 26, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchiodo @joyceerhl