Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge tests from test/common/argumentsHelper.unit.test.ts into test/testing/common/argsHelper.unit.test.ts #6583

Closed
kimadeline opened this issue Jul 15, 2019 · 0 comments
Closed

Merge tests from test/common/argumentsHelper.unit.test.ts into test/testing/common/argsHelper.unit.test.ts #6583

kimadeline opened this issue Jul 15, 2019 · 0 comments
Assignees
@kimadeline
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2019 - June Sprin...

Comments

@kimadeline
Copy link

When working on #6537 I added tests to src/test/common/argumentsHelper.unit.test.ts, but didn't realize we already had some in src/test/testing/common/argsHelper.unit.test.ts.

  • move relevant tests over to src/test/testing/common/argsHelper.unit.test.ts
  • delete the new file
@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jul 15, 2019
@kimadeline kimadeline self-assigned this Jul 15, 2019
@kimadeline kimadeline added this to the 2019 - June Sprint 13 milestone Jul 15, 2019
@kimadeline kimadeline mentioned this issue Jul 15, 2019
Merged
4 tasks
@ghost ghost removed the needs PR label Jul 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2019 - June Sprint 13
Development

No branches or pull requests
1 participant
@kimadeline