Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring with rope removes code when no newline at EOF #695

Closed
fbkarsdorp opened this issue Feb 2, 2018 · 1 comment · Fixed by #1748
Closed

Refactoring with rope removes code when no newline at EOF #695

fbkarsdorp opened this issue Feb 2, 2018 · 1 comment · Fixed by #1748
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@fbkarsdorp
Copy link

fbkarsdorp commented Feb 2, 2018

Environment data

VS Code version: 1.19.3
Python Extension version: 2018.1.0
Python Version: 3.6.4 (Anaconda)
OS and version: macOS 10.13.3
Rope version: 0.10.7

Actual behavior

When refactoring code that's missing a newline at the end of file, the last line of code gets deleted.

Expected behavior

Proper refactoring, without deleting the last line.

Steps to reproduce:

See the gif.
rope-new-line

@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug feature-refactoring labels Feb 2, 2018
@ericsnowcurrently ericsnowcurrently self-assigned this Feb 12, 2018
@ericsnowcurrently
Copy link
Member

@fbkarsdorp, thanks for letting us know about this problem. I've been able to duplicate it using rope 0.10.7 (the latest). We'll look into the cause (and the fix).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants