Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why NPM 6.11+ breaks our build #3134

Closed
IanMatthewHuff opened this issue Sep 4, 2019 · 5 comments
Closed

Figure out why NPM 6.11+ breaks our build #3134

IanMatthewHuff opened this issue Sep 4, 2019 · 5 comments
Assignees

Comments

@IanMatthewHuff
Copy link
Member

This is the build issue that hit us previously. Right now we are pinned at 6.10.3. But in 6.11+ we get an issue with -n command that we pass to webpack. NPM in this release had a number of issues with windows command lines and this issue on only showing on windows, so I would assume this is related (see notes in 6.11.1 6.11.2).

https://github.com/npm/cli/releases

@IanMatthewHuff
Copy link
Member Author

reported.

@IanMatthewHuff IanMatthewHuff self-assigned this Jan 3, 2020
@IanMatthewHuff
Copy link
Member Author

IanMatthewHuff commented Jan 3, 2020

npm/npx#5 - Open issue causing the problem
npm/npx#30 - Possible maintenance issues? This is npm version of npx. Previous version of this died here: zkat/npx#223

@IanMatthewHuff
Copy link
Member Author

Set max heap globally (which is why we were using npx I believe):
npm/npm#12238

Something like this works as a script:
cross-env NODE_OPTIONS=--max_old_space_size=9096 webpack --config webpack.config.js --mode production

@IanMatthewHuff
Copy link
Member Author

Seems like nyc needs an update as well:
istanbuljs/nyc#1205
istanbuljs/nyc#1104

I think 15 that just came out should fix windows nyc.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 9, 2020

Validated

@rchiodo rchiodo closed this as completed Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants