Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ptvsd wheels and new DA support to remote debugging API #7549

Closed
kimadeline opened this issue Sep 23, 2019 · 1 comment
Closed

Add ptvsd wheels and new DA support to remote debugging API #7549

kimadeline opened this issue Sep 23, 2019 · 1 comment
Assignees
Labels
area-debugging feature-request Request for new features or functionality

Comments

@kimadeline
Copy link

kimadeline commented Sep 23, 2019

Related to #7001 (parent meta issue is #6017)

We expose debugger commands to other extensions since #3121, this API should be modified to support the new ptvsd wheels (port? host? wait for debugger?):

export function buildApi(ready: Promise<any>) {
return {
// 'ready' will propogate the exception, but we must log it here first.
ready: ready.catch((ex) => {
traceError('Failure during activation.', ex);
return Promise.reject(ex);
}),
debug: {
async getRemoteLauncherCommand(host: string, port: number, waitUntilDebuggerAttaches: boolean = true): Promise<string[]> {
return new RemoteDebuggerExternalLauncherScriptProvider().getLauncherArgs({ host, port, waitUntilDebuggerAttaches });
}
}
};
}

@kimadeline kimadeline added feature-request Request for new features or functionality area-debugging experimenting Feature is part of an experiment labels Sep 23, 2019
@kimadeline kimadeline changed the title Add ptvsd wheels support to remote debugging API Add ptvsd wheels and new DA support to remote debugging API Sep 23, 2019
@kimadeline kimadeline added this to the 2019 - September Sprint 2 milestone Sep 23, 2019
@kimadeline kimadeline self-assigned this Sep 23, 2019
@karthiknadig karthiknadig self-assigned this Oct 1, 2019
@karthiknadig
Copy link
Member

Validated.

@ghost ghost removed experimenting Feature is part of an experiment needs PR labels Oct 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants