Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PythonExecutionService to support "conda run". #7696

Closed
4 of 15 tasks
ericsnowcurrently opened this issue Sep 30, 2019 · 4 comments
Closed
4 of 15 tasks

Update PythonExecutionService to support "conda run". #7696

ericsnowcurrently opened this issue Sep 30, 2019 · 4 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 30, 2019

This will involve the following:

  • change PythonExecutionService.pythonPath (a string) to PythonExecutionService.pyArgv (an array of strings)
  • update PythonExecutionService.create() to pass an array of strings to PythonExecutionService()
  • update PythonExecutionService.createActivatedEnvironment() to pass an array of strings to PythonExecutionService()
  • verify that the usage in the various places works properly for conda and non-conda:
    • formatting
      • src/client/formatters/baseFormatter.ts (via PythonToolExecutionService)
    • linting
      • src/client/linters/errorHandlers/notInstalled.ts
      • src/client/linters/baseLinter.ts (via PythonToolExecutionService)
    • testing
      • src/client/testing/common/services/discovery.ts
      • src/client/testing/common/runner.ts
      • src/client/testing/common/runner.ts (via PythonToolExecutionService)
    • installers
      • src/client/common/installer/pipInstaller.ts
      • src/client/common/installer/productInstaller.ts
    • debugger
      • src/client/debugger/extension/adapter/factory.ts
    • interpreter discovery
      • src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
      • src/client/interpreter/configuration/pythonPathUpdaterService.ts
      • src/client/interpreter/helpers.ts
      • src/client/interpreter/interpreterService.ts
      • src/client/interpreter/locators/services/windowsStoreInterpreter.ts
    • import sorting
      • src/client/providers/importSortProvider.ts
    • jedi
      • src/client/providers/jediProxy.ts
    • refactoring
      • src/client/refactor/proxy.ts
@ericsnowcurrently ericsnowcurrently added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Sep 30, 2019
@DonJayamanne DonJayamanne mentioned this issue Oct 9, 2019
24 tasks
@karthiknadig karthiknadig added this to the 2019 October Sprint 2 milestone Oct 9, 2019
@gramster gramster added area-environments Features relating to handling interpreter environments and removed feature-interpreter labels Oct 10, 2019
@kimadeline kimadeline self-assigned this Oct 21, 2019
@kimadeline
Copy link

Make sure conda run works with both named environment and non-named environment (where we have to use the path)

@kimadeline
Copy link

kimadeline commented Nov 25, 2019

To validate:

  • workspace with a named conda environment (conda create --name yourenv or conda create -n yourenv)
    • extension loads
    • extension selects the workspace correctly
    • formatting should be executed using conda run
    • linting should be executed using conda run
    • run in terminal should be executed using conda run
    • test discovery using pytest should be executed using conda run
  • workspace with a prefixed conda environment (conda create --prefix path/to/env)
    • extension loads
    • extension selects the workspace correctly
    • formatting should be executed using conda run
    • linting should be executed using conda run
    • run in terminal should be executed using conda run
    • test discovery using pytest should be executed using conda run

@kimadeline kimadeline assigned karrtikr and unassigned kimadeline Nov 25, 2019
@karrtikr
Copy link

validated

@ghost ghost removed the needs PR label Nov 25, 2019
@karrtikr
Copy link

karrtikr commented Nov 25, 2019

Found an unrelated issue while validating it. #8783

@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

5 participants