Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode symbol used to mark skipped tests is almost not visible on Linux and Windows #7705

Closed
kondratyev-nv opened this issue Oct 1, 2019 · 3 comments
Labels
area-testing bug Issue identified by VS Code Team member as probable bug

Comments

@kondratyev-nv
Copy link

Environment data

  • VS Code version: 1.38.1
  • Extension version (available under the Extensions sidebar): 2019.9.34911
  • OS and version: Ubuntu 19.04, Windows 10

Expected behaviour

CodeLens for skipped tests shows some distinctive mark indicating that this test is skipped.

Actual behaviour

The Unicode symbol used to mark skipped tests is almost not visible on Linux and Windows.
image

On Mac it shows correctly.
image

Steps to reproduce:

  1. Create a test class with skipped test, for example
import unittest


class AddTests(unittest.TestCase):
    def test_basic_two_plus_one_is_three_passed(self):
        self.assertEqual(3, 2 + 1)

    def test_basic_two_plus_two_is_five_failed(self):
        self.assertEqual(5, 2 + 2)

    @unittest.skip("Skipped for a very important reason")
    def test_basic_two_plus_zero_is_two_skipped(self):
        self.assertEqual(2, 2 + 0)

  1. Run all tests
  2. Test result mark in CodeLens is not visible for the skipped test.
@kondratyev-nv kondratyev-nv added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Oct 1, 2019
@kondratyev-nv
Copy link
Author

It looks like that the used Unicode symbol is combining character, see https://en.wikipedia.org/wiki/No_symbol. I can fix this myself and create a PR if this would be ok. But I would like to know what would be the best alternative? I found two - 🛇 and 🚫. This is how they look like
image

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 1, 2019
@kondratyev-nv
Copy link
Author

Well, I tried both options on Ubuntu, Windows, and Mac and it looks like the first one (🛇) is not displayed on Mac and the second one looks strange on Windows because it has a white background. I'll try to look for other options.

@karthiknadig
Copy link
Member

@kondratyev-nv If you find a symbol that works go ahead and make a PR.

@luabud luabud closed this as completed Oct 27, 2020
@ghost ghost removed the needs PR label Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants