Fix: sonar issues #7812
Merged
Fix: sonar issues #7812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #7812 +/- ##
==========================================
- Coverage 59.16% 58.93% -0.23%
==========================================
Files 498 498
Lines 22254 22293 +39
Branches 3578 3575 -3
==========================================
- Hits 13166 13139 -27
- Misses 8264 8332 +68
+ Partials 824 822 -2
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
Oct 8, 2019
| @@ -163,7 +163,7 @@ export class NativeEditorProvider implements INotebookEditorProvider, IAsyncDisp | |||
| const existing = await this.fileSystem.search(`${dir}/${localize.DataScience.untitledNotebookFileName()}-*.ipynb`); | |||
|
|
|||
| // Sort by number | |||
| const sorted = existing.sort(); | |||
| const sorted = [...existing].sort(); | |||
There was a problem hiding this comment.
There's no need to clone the array, you can use the same array as is. I.e. use existing instead of sorted
There was a problem hiding this comment.
I just pushed a commit that should address your suggestion.
rchiodo
approved these changes
Oct 14, 2019
|
@DonJayamanne did you want more changes on this? |
DonJayamanne
approved these changes
Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to address some of the sonar issues noted in #7745.
I do now know any typescript to address the the last few items left.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)