Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for control group in adapter experiments #7817

Closed
luabud opened this issue Oct 8, 2019 · 5 comments
Closed

Add telemetry for control group in adapter experiments #7817

luabud opened this issue Oct 8, 2019 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@luabud
Copy link
Member

luabud commented Oct 8, 2019

Currently we're getting telemetry only for those in the experiment groups for wheels and the new adapter, and not the ones in control

@luabud luabud added bug Issue identified by VS Code Team member as probable bug needs PR important Issue identified as high-priority labels Oct 8, 2019
@karthiknadig karthiknadig added this to the 2019 October Sprint 2 milestone Oct 9, 2019
@kimadeline
Copy link

kimadeline commented Oct 10, 2019

Prescribed solution:

  • call sendTelemetryIfInExperiment for the DA control group in src/client/debugger/extension/adapter/activator.ts
  • call sendTelemetryIfInExperiment for the wheel control group in src/client/debugger/extension/adapter/factory.ts
  • add telemetry unit tests for both experiments

Note: Experiment telemetry refactoring will be done in #7869

@kimadeline
Copy link

@luabud @karthiknadig should we close this issue now that the DA experiment is disabled?

@luabud
Copy link
Member Author

luabud commented Oct 21, 2019

I'd say we can close this once the experiment is back on and we start getting the telemetry events :)

@karthiknadig
Copy link
Member

This should be back after we merge #8119

@luabud
Copy link
Member Author

luabud commented Oct 21, 2019

Then it's being tracked elsewhere, so closing it.

@luabud luabud closed this as completed Oct 21, 2019
@ghost ghost removed the needs PR label Oct 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants