Run cell through shift enter in ipynb cause code lost

[xgdgsc]

Steps to cause the bug to occur

1. Edit an existing cell inside ipynb
2. press shift-enter

Actual & Expected behavior

Sometimes last edit would be lost and the code returns to what is before editing. While the output could be the new code generated.

Your Jupyter and/or Python environment

• Jupyter server running: Local
• Extension version: 2019.10.41019
• VS Code version: 1.38.1
• Setting python.jediEnabled: false
• Python and/or Anaconda version: 3.7.3
• OS: Linux (distro): Ubuntu 16.04
• Virtual environment: conda

Developer Tools Console Output

workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:27: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:35: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:53: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:53: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:53: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:53: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:53: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:07:54: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] No editors associated with document: /home/sgao/.config/Code/User/settings.json
t.log @ workbench.desktop.main.js:sourcemap:230
workbench.desktop.main.js:sourcemap:230 [Extension Host] No editors associated with document: /home/sgao/.config/Code/User/settings.json
t.log @ workbench.desktop.main.js:sourcemap:230
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:09: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:09:51: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:02: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:29: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:29: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:29: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:29: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:29: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:30: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:41: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:41: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:41: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:41: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:41: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:42: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:10:57: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:22: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Submitting code for d2390ea9-5d62-43d9-ae95-b2a7fb39373b
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Waiting for jupyter server and web panel ...
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Wait for sys info for d2390ea9-5d62-43d9-ae95-b2a7fb39373b 0
workbench.desktop.main.js:sourcemap:230 [Extension Host] Info Python Extension: 2019-10-09 18:11:27: Finished execution for e291f4ad-ca94-4e12-bf34-2622a6d58f08

[rchiodo]

Thanks for the feedback. We should either disable cell editing while running, or not overwrite the text if it's newer.

[cezarymierzejek]

I believe I am experiencing the same issue though more severe. Running a cell works fine in the native editor. But if I edit the cell and rerun (even if nothing else is running) then the cell reverts to its original code every time.

If I save the entire notebook before running the cell then the updated code runs as expected. I also tried reinstalling the Python extension and the issue continues to persist.

My Environment:
Jupyter server running: Local
Extension version: 2019.10.41019
VS Code version: 1.39.0
Setting python.jediEnabled: True
Python and/or Anaconda version: 3.7.4
OS: MacOS Catalina (10.15)
Virtual environment: conda

[xgdgsc]

Yes. Saving before running works.

[DonJayamanne]

@xgdsc @cezarymierzejek
Thanks for reporting this issue. I'm currently looking at this issue and am unable to replicate this at my end. Would you be able to provide detailed steps that I could use to repro at my end (or possibly a video/animated gif or the like).
Thanks

[cezarymierzejek]

@DonJayamanne
Please try the following:

1. Ctrl Shift P -> Create New Blank Jupyter Notebook
2. Type print('test this') in the new cell
3. Shift Enter
4. Go back to the cell and reduce the print statement to print('test')
5. Shift Enter - you should see it print 'test this' instead of 'test'

If you save the notebook after step 4 but before step 5 then it will print correctly. Please let me know if you are able to replicate.

[rchiodo]

Validated