Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real Jupyter functional tests on Windows take far too long #2903

Closed
IanMatthewHuff opened this issue Oct 15, 2019 · 6 comments
Closed

Real Jupyter functional tests on Windows take far too long #2903

IanMatthewHuff opened this issue Oct 15, 2019 · 6 comments
Assignees

Comments

@IanMatthewHuff
Copy link
Member

I've had to bump up the timeout way up for the nightly flake suites. And it's just windows causing this issue. My quick guess is that it's the "locate the right jupyter to launch" code, as I think that multiple SxS versions of Python are installed on the test boxes.

@karthiknadig
Copy link
Member

Is there any thing that extension team should investigate here? This does not look like something we can address.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 20, 2019

Oops that's was accidental, adding DS label back

@rchiodo
Copy link
Contributor

rchiodo commented Feb 20, 2020

Following the directions here:
https://stackoverflow.com/questions/42997898/how-to-enable-source-map-support-for-node-js-prof-process

and by making a new test entry like this in the package.json:

        "test:functional:perf": "node --inspect-brk ./node_modules/mocha/bin/_mocha --require source-map-support/register --opts ./build/.mocha.functional.perf.opts",

I can profile the tests.

@rchiodo
Copy link
Contributor

rchiodo commented Feb 20, 2020

Additionally using this is also possible, just not as nice of an output:
https://nodejs.org/en/docs/guides/simple-profiling/

@rchiodo
Copy link
Contributor

rchiodo commented Feb 20, 2020

Looks like the majority of the time is enumerating interpreters by asking the registry. We do this on every test.

Hotspots:

  • getInterpretersFromRegistry
  • getInterpreterDetails

@rchiodo rchiodo self-assigned this Feb 20, 2020
@IanMatthewHuff IanMatthewHuff self-assigned this Feb 25, 2020
@IanMatthewHuff
Copy link
Member Author

Validated via the most recent test results timing. Now just 2x linux mac and only 1 hour.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants