Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memento storage contents trumps file contents even if file is newer #2895

Closed
rchiodo opened this issue Oct 16, 2019 · 2 comments
Closed

Memento storage contents trumps file contents even if file is newer #2895

rchiodo opened this issue Oct 16, 2019 · 2 comments
Assignees
@DonJayamanne

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 16, 2019

  1. Create a notebook file (make sure it's saved)
  2. Add some content
  3. Close VS code
  4. Edit notebook outside of VS code
  5. Reopen VS code
  6. Reopen file

Expected result: File contents are there
Actual result: Last contents from closing VS code is there
@DonJayamanne DonJayamanne self-assigned this Oct 21, 2019
@rchiodo rchiodo assigned rchiodo and unassigned rchiodo Oct 24, 2019
@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 25, 2019

Mostly validated except when reopening from storage, not marked dirty anymore.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 25, 2019

Okay the not dirty only happens if opening from a different workspace. So not a big deal.

@rchiodo rchiodo closed this as completed Oct 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @rchiodo