Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMD+S does not work to save a notebook #2819

Closed
rchiodo opened this issue Oct 22, 2019 · 2 comments
Closed

CMD+S does not work to save a notebook #2819

rchiodo opened this issue Oct 22, 2019 · 2 comments
Assignees
@IanMatthewHuff @DonJayamanne

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 22, 2019

Splitting this off from microsoft/vscode-python#7993 as we need to fix this part at least.

CTRL+S works on windows, but CMD+S does not work on mac
@rchiodo rchiodo assigned rchiodo and unassigned rchiodo Oct 23, 2019
@DonJayamanne DonJayamanne self-assigned this Oct 25, 2019
@IanMatthewHuff IanMatthewHuff self-assigned this Oct 29, 2019
@IanMatthewHuff
Copy link
Member

Hey Don. Cmd+S does save now, but it looks like the fix on my review comment to not allow ctrl+s to save didn't work. They both save still. Looks like the commit added only checks OSX for the cmd case, the ctrl+s is still let through for both Windows and Mac.

@IanMatthewHuff
Copy link
Member

Validated.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IanMatthewHuff IanMatthewHuff

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanMatthewHuff @DonJayamanne @rchiodo