-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear the saved jupyter interpreter path if it fails to launch #2355
Comments
I vote for number 3 |
This feels like a regression to me. It wouldn't have done this before |
Yeah, folks won't be removing interpreters all the time, but it's not that rare. And it's pretty bad when you get into this state. Plus the user has no idea that the first time they successfully launch Jupyter that they have set this internal setting. |
Note. I was not able to repro the situation where I was failing and didn't see the missing dependencies popup. When I deleted or removed jupyter from the saved jupyter interpreter I always got the missing dependencies popup. So I added the target interpreter to that dialog (so the user can see what they are trying to use) and improved the help link. |
Hmm. I can repro this if I set the jupyter interpreter to something that doesn't support it. Like a virtual env with jupyter. |
@rchiodo Sorry what's an example of this "Like a virtual env with jupyter." A virtual env with Jupyter installed should work just fine. Do you mean if you delete that env? |
On windows I can't get a virtualenv (one created with venv) to work. I installed the default python from the store, then create a venv for juptyer, pip install jupyter and try running a notebook. The kernel will crash. If you set this as your selected jupyter interpreter, we never recover. |
Hmm virtualenvs from venv work just fine for me. Not fully sure if I really want to fudge up my system by installing the default python. I'll try to check it out this afternoon. |
Works for me. |
Validated. Removed jupyter from a selected interpreter that was already working and it just moved onto the new one automatically. |
Validated |
Result:
Jupyter will not start. However you won't get a popup on this or a notification of what interpreter it was trying to use. You just get a call stack of our code (NativeEditor.startServer ect..) displayed in the output cell.
Expected:
Any of the following would help:
The text was updated successfully, but these errors were encountered: