Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-tw translation of Quickopen command #841

Merged
merged 8 commits into from
Feb 21, 2018

Conversation

uranusjr
Copy link

Based on #496. I made changes according to comments there, but also add some more modifications (as denoted in the commit message. It might be best if we can get some additional review before merging. @godfat

gogobook and others added 7 commits February 21, 2018 14:26
Use full-width colons, paretheses, and ellipses, as standard in Chinese.
The original text, "debug", is usually translated in Taiwan as "除錯" or
"偵錯". The previous translation "測試" is probably a misunderstanding
to Simplified Chinese, which uses "调试". In China "调试" and "测试"
refer to similar, but distinct concepts (test and debug, respectively).
On furthur research it seems Microsoft generally translates "debug" to
"偵錯", and "debugger" to "偵錯工具". Conform to that since this is
Visual Studio Code.
@msftclas
Copy link

msftclas commented Feb 21, 2018

CLA assistant check
All CLA requirements met.

Copy link

@godfat godfat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/程序/程式/g

Otherwise looks good to me! Thanks!

"python.snippet.launch.module.label": "Python:模組",
"python.snippet.launch.module.description": "偵錯 Python 模組",
"python.snippet.launch.terminal.label": "Python:終端機(整合)",
"python.snippet.launch.terminal.description": "使用整合終端機偵錯 Python 程序",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 程式

"python.snippet.launch.terminal.label": "Python:終端機(整合)",
"python.snippet.launch.terminal.description": "使用整合終端機偵錯 Python 程序",
"python.snippet.launch.externalTerminal.label": "Python:終端機(外部)",
"python.snippet.launch.externalTerminal.description": "使用外部終端機偵錯 Python 程序",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 程式

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #841 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   63.46%   63.42%   -0.04%     
==========================================
  Files         258      258              
  Lines       11845    11861      +16     
  Branches     2104     2115      +11     
==========================================
+ Hits         7517     7523       +6     
- Misses       4320     4330      +10     
  Partials        8        8
Impacted Files Coverage Δ
...t/interpreter/configuration/interpreterSelector.ts 43.26% <0%> (-4.46%) ⬇️
...ient/interpreter/locators/services/condaService.ts 97.32% <0%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e543b...2dda510. Read the comment docs.

For consistency and conforming to typical Taiwan usage.
@uranusjr
Copy link
Author

Oops, missed those two. Thanks for the catch!

@brettcannon brettcannon merged commit bfe3490 into microsoft:master Feb 21, 2018
@brettcannon
Copy link
Member

Thanks for this @uranusjr and @godfat !

@uranusjr uranusjr deleted the quickopen-zhtw branch February 22, 2018 01:45
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants