-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zh-tw translation of Quickopen command #841
Conversation
Use full-width colons, paretheses, and ellipses, as standard in Chinese.
Based on suggestions by @godfat in microsoft#496.
The original text, "debug", is usually translated in Taiwan as "除錯" or "偵錯". The previous translation "測試" is probably a misunderstanding to Simplified Chinese, which uses "调试". In China "调试" and "测试" refer to similar, but distinct concepts (test and debug, respectively).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/程序/程式/g
Otherwise looks good to me! Thanks!
package.nls.zh-tw.json
Outdated
"python.snippet.launch.module.label": "Python:模組", | ||
"python.snippet.launch.module.description": "偵錯 Python 模組", | ||
"python.snippet.launch.terminal.label": "Python:終端機(整合)", | ||
"python.snippet.launch.terminal.description": "使用整合終端機偵錯 Python 程序", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 程式
package.nls.zh-tw.json
Outdated
"python.snippet.launch.terminal.label": "Python:終端機(整合)", | ||
"python.snippet.launch.terminal.description": "使用整合終端機偵錯 Python 程序", | ||
"python.snippet.launch.externalTerminal.label": "Python:終端機(外部)", | ||
"python.snippet.launch.externalTerminal.description": "使用外部終端機偵錯 Python 程序", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 程式
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
- Coverage 63.46% 63.42% -0.04%
==========================================
Files 258 258
Lines 11845 11861 +16
Branches 2104 2115 +11
==========================================
+ Hits 7517 7523 +6
- Misses 4320 4330 +10
Partials 8 8
Continue to review full report at Codecov.
|
For consistency and conforming to typical Taiwan usage.
Oops, missed those two. Thanks for the catch! |
Based on #496. I made changes according to comments there, but also add some more modifications (as denoted in the commit message. It might be best if we can get some additional review before merging. @godfat