Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection menu: Not all actions work on read only editors #16627

Closed
aeschli opened this issue Dec 6, 2016 · 4 comments
Closed

Selection menu: Not all actions work on read only editors #16627

aeschli opened this issue Dec 6, 2016 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@aeschli
Copy link
Contributor

aeschli commented Dec 6, 2016

Testing #16558

  • In the git view, select a file that was removed.

  • set focus to the editor and try the actions from the selection menu

    • set cursor above/below doesn't seem to have an effect
    • move/copy lines don't have an effect
  • Unavailable actions should better be disabled. or maybe there should be some feed back.

  • set cursor above/below should also work in a readonly editor

@alexdima
Copy link
Member

alexdima commented Dec 7, 2016

I have extracted the last bullet point to a new issue. For the rest of the bullet points, the top level menu should be updated based on the current focused editor.

e.g.

  1. Close all editors. Click on Selection Menu. It should contain only disabled items.
  2. Focus in the terminal. Click on anything in the Selection Menu, etc.

@alexdima alexdima assigned chrmarti and unassigned alexdima Dec 7, 2016
@bpasero
Copy link
Member

bpasero commented Dec 8, 2016

Related: #991

@chrmarti chrmarti added feature-request Request for new features or functionality workbench labels Dec 8, 2016
@chrmarti
Copy link
Contributor

Same with the Edit menu. This is by design at the moment.

@bpasero
Copy link
Member

bpasero commented Jul 13, 2018

Duplicate of #991

@bpasero bpasero marked this as a duplicate of #991 Jul 13, 2018
@bpasero bpasero closed this as completed Jul 13, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants