Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkey for displaying a hidden menu is accepted even when combined with other modifier keys #22488

Closed
axefrog opened this issue Mar 12, 2017 · 2 comments
Closed

Hotkey for displaying a hidden menu is accepted even when combined with other modifier keys #22488

axefrog opened this issue Mar 12, 2017 · 2 comments
Assignees
@bpasero @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
September 2018

Comments

@axefrog
Copy link

axefrog commented Mar 12, 2017

  • VSCode Version: 1.10.2
  • OS Version: Windows 10

Steps to Reproduce:

  1. Set the menu to hidden by default
  2. Leave the hotkey for showing the menu as the default (ALT in my case)
  3. Press ALT + CTRL or ALT + SHIFT
  4. The menu is displayed on key release

It is pretty common for me to start to use a hotkey combination and then change my mind and let go of the modifier keys before pressing the main hotkey. If those modifiers included the ALT key, the menu is displayed even if other modifier keys were also being pressed at the same time.
@bpasero
Copy link
Member

bpasero commented Mar 13, 2017

The only workaround for now is window.menuBarVisibility: hidden but that also means that the menu never shows up, not even on Alt press.

@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 13, 2017
@bpasero bpasero added this to the Backlog milestone Mar 13, 2017
@bpasero bpasero added the menu label May 26, 2017
@bpasero bpasero removed the workbench label Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@sbatten sbatten mentioned this issue May 10, 2018
Closed
@dmke dmke mentioned this issue May 17, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Aug 17, 2018

We will change to custom menus on Windows. For now you can set "window.titleBarStyle": "custom".

@bpasero bpasero closed this as completed Aug 17, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 17, 2018
@bpasero bpasero added this to the August 2018 milestone Aug 17, 2018
@dbaeumer dbaeumer modified the milestones: August 2018, September 2018 Aug 30, 2018
@roblourens roblourens added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
6 participants
@axefrog @roblourens @bpasero @dbaeumer @sbatten @ramya-rao-a