-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to theme the entire workbench #3112
Comments
+1. I get a lot of people asking for this for my theme. I assume a lot of theme developers do. |
Can we get some feedback on this ? |
+1 Please add sidebar coloring theme |
Very much agree with |
+100 |
Currently, themes other than the default tend to look kinda awkward when displayed alongside the toolbar and sidebar. See, for instance, how it can change the general look and feel when using something like VScode Custom CSS extension. |
+1 |
1 similar comment
+1 |
Themes looks particularly bad when the background is neither particularly dark or light: https://marketplace.visualstudio.com/items?itemName=rebornix.nova |
@bpasero can we expect support for setting |
I've switched to insiders so I can test the I'm not sure if these are issues with the theme or the theming support but I've tried to find all the ui areas that I think aren't themed yet. Some are pretty minor but hopefully it helps. Autocomplete boxBackground on startupButton outline in debug panelDisable and uninstall buttonsVscode feedback popupRight sidebar in git diff viewSearch and replace dropdown on hoverSelected tab underline in bottom trayTotal settings count background and gray linesSidebar file selection highlighting.
Welcome page quick links |
@bpasero So at the moment we can only change the statusbar color? "workbench.experimental.colorCustomizations": {
"statusBarBackground": "#00EECC",
"statusBarNoFolderBackground": "#CCEE00",
"statusBarDebuggingBackground": "#CCFFFF"
} |
@psuedosudo thanks, maybe you could add this to #23506 where we already collect missing elements. We are well aware of some, since we have not adopted all widgets yet (e.g. like the tree/list widget that is pretty much everywhere). @equinusocio no, the list of colors is larger. Once you open intellisense in settings you will see all: |
@bpasero Ah nice work! There will be a documentation section about that API? |
Yes, we are just wrapping up for the March release and plan to document theming soon. We still expect many changes to the theming API though (color keys) during April. |
Oks! Thank you! |
I'm very excited about this. Are we going to be able to change the text color/format of tabs via extensions? |
@bpasero How we can define settings inside the extension? there is a place to put the colors settings? I have a textmate theme, not a json schema |
Thanks a lot for the new update, We all wanted for this so much ❤️ One thing: As I mentioned in #21938 it would be really really cool if the activity bar could be themed light. And the problem still exists because the icons remain white: |
for themeable icons, i suggest to adapt KDE’s approach (and please no slight modification of it, it would be amazing if something in the software would would be actually compatible for once) |
@flying-sheep Thanks for the link, didn't know that trick! |
idk if it’s a trick, but the idea is of course to replace the |
@flying-sheep what a nice system! |
Are the plans to be able to customize the search results view? |
It would be nice to change:
|
Support for theming the workbench has landed for April release (1.12.x) and is documented in our release notes: https://code.visualstudio.com/updates/v1_12#_workbench-theming We close this issue and reference other related issues that were mentioned in discussions in this issue as follow up:
We still plan to add more components that are themable as we see fit and requests for. |
Currently, color themes are not getting applied to the toolbar on the left:
I tend to believe this is not intentional as it inhibits accessibility, e.g. with high-contrast themes.
So I propose to have themes apply to the VS Code toolbar, too.
The text was updated successfully, but these errors were encountered: