Fix sending message to terminated worker #10833
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paveldk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
paveldk
force-pushed
the
pkolev/fix-terminated-worker
branch
from
c3b7f7e to
996cf99
Compare
paveldk
force-pushed
the
pkolev/fix-terminated-worker
branch
from
996cf99 to
b241866
Compare
|
@dbaeumer Please reassign if you do not own this. |
|
Nice catch! Looks good! Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem appears if you create multiple editors/models and then change the typescript compilation settings. This will dispose (terminate) the worker as first action. then it will dispose all existing models which will try to send messages for "acceptRemovedModel" to the worker(s) but as they are already terminated this will result in error.
I'm not sure if it is a better if the worker is terminated to reject the postMessage request immediately since this will again result in error.