Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'uri' of null fix #13263

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Conversation

jwchang0206
Copy link
Contributor

@jwchang0206 jwchang0206 commented Oct 5, 2016

There is a case that throw TypeError: Cannot read property 'uri' of null when I try to construct and remove the monaco editor in short amount of time in an web app. The setModelMarkers is in call stack already while the model is already removed.

@mention-bot
Copy link

@inspiredjw, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima, @egamma and @sandy081 to be potential reviewers.

@msftclas
Copy link

msftclas commented Oct 5, 2016

Hi @inspiredjw, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Jeong Woo Chang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.235% when pulling de65f69 on inspiredjw:patch-1 into 61328fd on Microsoft:master.

@alexdima alexdima added this to the October 2016 milestone Oct 24, 2016
@alexdima alexdima merged commit de65f69 into microsoft:master Oct 24, 2016
alexdima added a commit that referenced this pull request Oct 24, 2016
Cannot read property 'uri' of null fix
@alexdima
Copy link
Member

Thank you for the contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants