Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase datacollector initial communication timeout #1355

Merged
merged 9 commits into from
Jan 8, 2018

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Jan 2, 2018

Description

  • Increase datacollector initial communication timeout to 30 sec.
  • Provide environment variable to config datacollector initial communication timeout.
  • Add more logging(print whole stacktrace, and update messagelevel).

Related issue

#1354

@smadala smadala self-assigned this Jan 2, 2018
@smadala smadala requested a review from cltshivash January 5, 2018 06:41
@singhsarab
Copy link
Contributor

                EqtTrace.Info(@"TestRequestSender: VersionCheck Succeeded, NegotiatedVersion = {0}", this.protocolVersion);

Remove these, as this would already have been logged.


Refers to: src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs:169 in 1980aa0. [](commit_id = 1980aa0, deletion_comment = False)

Copy link
Contributor

@singhsarab singhsarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

}
}

private void ChangeConnectionTimeoutIfRequired(int processId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a similar utility method for ProxyExecutionManager, can you please check it, & merge the two.

@smadala smadala merged commit cc8957a into microsoft:master Jan 8, 2018
@smadala smadala deleted the increase-dc-timeout branch January 8, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants