Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trx logger class name fix - NUnit data driven tests #1677

Merged
merged 7 commits into from
Jul 11, 2018
Merged

Trx logger class name fix - NUnit data driven tests #1677

merged 7 commits into from
Jul 11, 2018

Conversation

abhishkk
Copy link
Contributor

@abhishkk abhishkk commented Jul 6, 2018

Description

Example:

        [TestCase(2, 2, 4.0)]
        public void TestMethod1(int a, int b, double c)
        {
            Assert.IsTrue(a + b == c);
        }

For above example, trx file has className as UnitTestProject1.UnitTest1.TestMethod1(2, 3, 4..
Ideally className should be UnitTestProject1.UnitTest1

Related issue

microsoft/azure-pipelines-tasks#7620

nigurr
nigurr approved these changes Jul 6, 2018
View reviewed changes
Copy link

@nigurr nigurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you have written all possible tests for this

smadala
smadala approved these changes Jul 6, 2018
View reviewed changes
src/Microsoft.TestPlatform.Extensions.TrxLogger/Utility/Converter.cs Outdated
}
}
catch (ArgumentException)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logging here.

test/Microsoft.TestPlatform.Extensions.TrxLogger.UnitTests/Utility/ConverterTests.cs
}

[TestMethod]
public void ToTestElementShouldContainExpectedTestMethodPropertiesIfFqnEndsWithTestName()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY; use datarow here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed dry

@abhishkk abhishkk closed this Jul 6, 2018
@abhishkk abhishkk reopened this Jul 6, 2018
@abhishkk abhishkk closed this Jul 9, 2018
@abhishkk abhishkk reopened this Jul 9, 2018
@abhishkk abhishkk merged commit 4076ff0 into microsoft:master Jul 11, 2018
@smadala smadala mentioned this pull request Aug 9, 2018
Closed
@stefanforsberg stefanforsberg mentioned this pull request Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigurr nigurr nigurr approved these changes

@smadala smadala smadala approved these changes

@singhsarab singhsarab Awaiting requested review from singhsarab

@cltshivash cltshivash Awaiting requested review from cltshivash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishkk @smadala @nigurr