Use Culture Specified by User in case it differs with that of OS #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
suggested changes
Aug 1, 2018
| CultureInfo.DefaultThreadCurrentUICulture = info; | ||
| } | ||
| catch (Exception) | ||
| { |
There was a problem hiding this comment.
Do EqtTrace here. ConsoleOutput not useful in datacollector process.
src/testhost.x86/Program.cs
Outdated
|
|
||
| private static void SetCultureSpecifiedByUser() | ||
| { | ||
| var userCultureSpecified = Environment.GetEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE"); |
| return new Executor(ConsoleOutput.Instance).Execute(args); | ||
| } | ||
|
|
||
| private static void SetCultureSpecifiedByUser() |
There was a problem hiding this comment.
Specify where it should be common for all these 3 different application
| try | ||
| { | ||
| CultureInfo info = new CultureInfo(userCultureSpecified); | ||
| CultureInfo.DefaultThreadCurrentUICulture = info; |
There was a problem hiding this comment.
Add example testing to PR description.
nguerrera
reviewed
Aug 1, 2018
| try | ||
| { | ||
| CultureInfo info = new CultureInfo(userCultureSpecified); | ||
| CultureInfo.DefaultThreadCurrentCulture = info; |
There was a problem hiding this comment.
In CLI, we don't change the formatting culture (CurrentCulture) based on DOTNET_CLI_UI_LANGUAGE, only the translation culture (CurrentUICulture).
|
@acesiddhu , @singhsarab , @smadala , Can one of you review it? |
smadala
approved these changes
Aug 3, 2018
|
added tests for app domain culture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set Current Culture to be the one propagated by dotnet via
DOTNET_CLI_UI_LANGUAGETest:
set DOTNET_CLI_UI_LANGUAGE=fr
run vstest.console /?
You should see help displayed in french
Related issue
Fixes #821.