Fix for video datacollector throwing exception #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red tests. Do not send TestCaseEnd for testcases whose TestCaseStart has not been recorded via adapter.
mayankbansal018
approved these changes
Aug 7, 2018
…test into fixDCStartEndIssue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: Video data collector throwing unexpected exception for ordered tests.
RCA: Ordered tests contain other tests, ordered test adapter does not raise the TestCaseStart for these child test cases.
RecordResult records TestCaseEnd if not recorded previously but does not check if RecordStart happened.
Fix: Do not send TestCaseEnd for testcases whose TestCaseStart has not been recorded via adapter.
Related issue
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/650935