Fixed issue where proc dump was not getting terminated on no crash #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaadhina
reviewed
Nov 22, 2018
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameCollector.cs
Outdated
Show resolved
Hide resolved
cltshivash
reviewed
Nov 22, 2018
| } | ||
| catch (Exception e) | ||
| { | ||
| EqtTrace.Info($"ProcessDumpUtility : Failed to kill proc dump process with exception {e}"); |
There was a problem hiding this comment.
Info [](start = 25, length = 4)
nitpick: warning
singhsarab
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue where proc dump was not getting terminated on no crash
Related issue
Related to issue in VSO.CI where results directory was not getting cleaned up due to proc dump having a handle on a dump file after the execution completion
And a few formatting fixes in and around the code touched.