Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Microsoft.NET.Test.Sdk to net40 and fix casing of msbuild files #1860

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Dec 5, 2018

Fixes #1850
Fixes #1863

There is still the dependency to Microsoft.CodeCoverage with net45 but a downgrade isn't possible here as Microsoft.CodeCoverage builds on netstandard1.0 which isn't supported with net40.

<group targetFramework="net45">
        <!-- TestHost gets shipped with vstest.console -->
        <dependency id="Microsoft.CodeCoverage" version="$Version$" />
      </group>
    </dependencies>

@ViktorHofer
Copy link
Member Author

@singhsarab
Copy link
Contributor

@ViktorHofer Have you validated that the props is getting honored for a net40 project ?

@ViktorHofer ViktorHofer changed the title Downgrade Microsoft.Net.Test.Sdk to net40 Downgrade Microsoft.NET.Test.Sdk to net40 Dec 7, 2018
@ViktorHofer ViktorHofer changed the title Downgrade Microsoft.NET.Test.Sdk to net40 Downgrade Microsoft.NET.Test.Sdk to net40 and fix casing of msbuild files Dec 7, 2018
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Dec 7, 2018

Yes just verified that the referencing the package from a net40 app works fine and the props and targets files are honored.

@singhsarab singhsarab merged commit 76fd0f5 into microsoft:master Dec 10, 2018
@singhsarab
Copy link
Contributor

@ViktorHofer Thanks for the contribution 👍

@ViktorHofer ViktorHofer deleted the Net40TestSdk branch December 10, 2018 15:39
@ViktorHofer
Copy link
Member Author

You are welcome. Please let me know if/when you push a new package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants