First Draft for the Protocol tool. #306
Conversation
Emits the json sent and recieved for Discovery, RunAll, RunSelected scenarios.
- Removed the runnerlocation, adapter and testhost configs.
|
|
||
| process.Start(); | ||
| process.EnableRaisingEvents = true; | ||
| process.Exited += Process_Exited; |
There was a problem hiding this comment.
process.EnableRaisingEvents and process.Exited should be invoked before process.Start()
Reference : https://msdn.microsoft.com/en-us/library/system.diagnostics.process.exited(v=vs.110).aspx
| processManager.StartProcess(new string[2] { parentProcessIdArgs, portArgs }); | ||
|
|
||
| communicationManager.AcceptClientAsync(); | ||
| communicationManager.WaitForClientConnection(Timeout.Infinite); |
There was a problem hiding this comment.
Any reason why communicationManager.AcceptClientAsync method is async? Just after calling this method, you are making a blocking call to communicationManager.WaitForClientConnection(Timeout.Infinite).
Suggestion : It can be changed to something like this:
communicationManager.AcceptClient();
(Make relevant changes in implementaion of AcceptClient method)
And there is no need to have this call :
communicationManager.WaitForClientConnection(Timeout.Infinite);
| private const string PORT_ARGUMENT = "/port:{0}"; | ||
| private const string PARENT_PROCESSID_ARGUMENT = "/parentprocessid:{0}"; | ||
|
|
||
| private static SocketCommunicationManager communicationManager; |
There was a problem hiding this comment.
Any specific reason for making this variable as static?
Emits the json sent and recieved for Discovery, RunAll, RunSelected scenarios.