Protocol v2 changes #672

singhsarab · 2017-03-30T06:01:31Z

Enable use of new Message type.
Protocol version check between runner and host
Object model changes for reducing the verbosity.
Serializers for supported protocol versions.
Unit tests

Related to #396.

2. Protocol version check between runner and host 3. Object model changes for reducing the verbosity. 4. Serializers for supported protocol versions. 5. Unit tests

msftclas · 2017-03-30T06:01:36Z

@singhsarab,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Changing the TestCase and TestResult objects, and cleaned up the converters.

AbhitejJohn · 2017-04-03T21:05:43Z

src/Microsoft.TestPlatform.CommunicationUtilities/Interfaces/ITestRequestSender.cs

+        /// Used for protocol version check with TestHost
+        /// </summary>
+        /// <returns>true if the version check is successful</returns>
+        bool CheckVersionWithTestHost();


would this be used for data collector as well?

Datacollector will always be bundled with the test runner. So they can communicate in any protocol without any negotiation?

AbhitejJohn · 2017-04-04T05:57:38Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

-                retValue = message.Payload.ToObject<T>(serializer);
-            }
+            var versionedMessage = message as VersionedMessage;
+            var serializer = versionedMessage?.Version == 2 ? payloadSerializer2 : payloadSerializer;


can we have a GetPayloadSerializer(Constants.CurrentVersion) for this? This can then be reused everywhere here.

AbhitejJohn · 2017-04-04T05:58:43Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

-            if (MessageType.TestMessage.Equals(message.MessageType))
-            {
-                retValue = message.Payload.ToObject<T>();
-            }


Assuming MessageType.TestMessage would continue to work post this change.

AbhitejJohn · 2017-04-04T05:59:35Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

@@ -20,26 +19,33 @@ public class JsonDataSerializer : IDataSerializer
    {
        private static JsonDataSerializer instance;

-        private static JsonSerializer serializer;
+        private static JsonSerializer payloadSerializer;
+        private static JsonSerializer payloadSerializer2;


an array maybe?

AbhitejJohn · 2017-04-04T06:01:36Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

        /// <returns>JSON string.</returns>
-        public string Serialize<T>(T data)
+        public string Serialize<T>(T data, int version = 1)


shouldn't this by default be the highest?

AbhitejJohn · 2017-04-04T06:06:36Z

src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs

@@ -28,18 +28,29 @@ public sealed class TestRequestSender : ITestRequestSender

        private IDataSerializer dataSerializer;

+        // TODO:sasin Change the version to 2


when would this change to 2?

Most likely in next PR, once IDE to runner is complete.

AbhitejJohn · 2017-04-04T06:10:18Z

src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs

@@ -76,23 +87,51 @@ public void Close()
        }

        /// <inheritdoc/>
+        public bool CheckVersionWithTestHost()


This reminds me - These RFCs(1 ,2) are now out of date. Should those change?

AbhitejJohn · 2017-04-04T06:16:49Z

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs

+                // Handling special case for dotnet core projects with older test hosts
+                // Older test hosts are not aware of protocol version check
+                // Hence we should not be sending VersionCheck message to these test hosts
+                bool checkRequired = true;


Is it the ProxyOperationManagers responsibility to perform this check? Or should this be part of an Initialize in RequestSender?

AbhitejJohn · 2017-04-04T06:19:36Z

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs

+                // Hence we should not be sending VersionCheck message to these test hosts
+                bool checkRequired = true;
+                var property = this.testHostManager.GetType().GetRuntimeProperties().FirstOrDefault(p => string.Equals(p.Name, versionCheckPropertyName, StringComparison.OrdinalIgnoreCase));
+                if (property != null)


Don't really know if there is something better we can do here. Seems odd :(
Maybe have a config file with the version and check for its existence?

AbhitejJohn · 2017-04-04T06:22:44Z

src/Microsoft.TestPlatform.ObjectModel/TestObject.cs

@@ -29,6 +29,11 @@ public abstract class TestObject
        private readonly Dictionary<TestProperty, object> store;

        /// <summary>
+        /// The store for all the local properties registered.
+        /// </summary>
+        private readonly Dictionary<TestProperty, object> localStore;


So, this wont be a breaking change to extensions right?

No, it wont.

AbhitejJohn · 2017-04-04T06:25:55Z

src/Microsoft.TestPlatform.ObjectModel/TestResult.cs

@@ -383,12 +383,7 @@ public static class TestResultProperties
        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Security", "CA2104:DoNotDeclareReadOnlyMutableReferenceTypes")]
        public static readonly TestProperty ErrorStackTrace = TestProperty.Register("TestResult.ErrorStackTrace", Resources.Resources.TestResultPropertyErrorStackTraceLabel, typeof(string), typeof(TestResult));
 #endif
-
-        private static bool ValidateComputerName(object value)


We don't like this? Why?

codito · 2017-04-04T11:39:50Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

+            payloadSerializer2 = JsonSerializer.Create(jsonSettings);
+
+            payloadSerializer.ContractResolver = new TestPlatformContractResolver1();
+            payloadSerializer2.ContractResolver = new DefaultTestPlatformContractResolver();


When v3 comes in, we need to change this code? Why not consider versioning the ContractResolvers suffixed with version number. The class name need not say what's default, let it be determined only in this file.

E.g. TestPlatformContractResolver2 for payloadSerializer2.

codito · 2017-04-04T11:42:14Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

-            {
-                retValue = message.Payload.ToObject<T>(serializer);
-            }
+            var versionedMessage = message as VersionedMessage;


Please log the default serializer determined here.

codito · 2017-04-04T11:45:56Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

        /// <typeparam name="T">Target type to deserialize.</typeparam>
        /// <returns>An instance of <see cref="T"/>.</returns>
-        public T Deserialize<T>(string json)
+        public T Deserialize<T>(string json, int version = 1)


Should the caller be aware of version of payload? How would it know, since the version is embedded inside the json?

This is just the payload deserialization, caller reads the version from the message.

codito · 2017-04-04T11:47:36Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

-            {
-                serializedPayload = JToken.FromObject(payload, serializer);
-            }
+            var serializedPayload = JToken.FromObject(payload, payloadSerializer);


Why are these APIs not using versioned messages? How would the caller decide which API to use (and when)?

We might want to change the APIs.
This is used for payload serialization/deserialization. Currently, the APIs caller reads the version beforehand

codito · 2017-04-04T11:49:51Z

src/Microsoft.TestPlatform.CommunicationUtilities/Messages/VersionedMessage.cs

+namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities
+{
+    /// <summary>
+    /// New construct with version used for communication


New becomes old ;) Better to not keep a sense of time in documentation. Add a remark specifying which version of vstest this was introduced and that this is the default message for protocol 2+.

codito · 2017-04-04T12:02:30Z

src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestCaseConverter.cs

+    using Newtonsoft.Json;
+
+    /// <inheritdoc/>
+    public class TestCaseConverter : JsonConverter


Not clear when this is used, why is it required. Require documentation.

codito · 2017-04-04T12:07:33Z

src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestResultConverter.cs

+    using Newtonsoft.Json;
+
+    /// <inheritdoc/>
+    public class TestResultConverter : JsonConverter


Require documentation. Should we include these classes in versioned folders (same for TestCaseConverter)?

codito · 2017-04-04T12:12:11Z

...ft.TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestCaseSerializationTests.cs

@@ -28,6 +28,8 @@ public class TestCaseSerializationTests
                                                   Traits = { new Trait("Priority", "0"), new Trait("Category", "unit") }
                                               };

+        #region v1 Tests


Require test where a TestCase doesn't have any properties and can be serialized properly.

codito · 2017-04-04T12:14:21Z

src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs

+        /// <param name="payload">Payload for the message.</param>
+        /// <param name="version">Version for the message.</param>
+        /// <returns>Serialized message.</returns>
+        public string SerializePayload(string messageType, object payload, int version)


How is this tested?

codito · 2017-04-04T12:19:13Z

....TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestResultSerializationTests.cs

            Assert.AreEqual("TestResult.EndTime", properties[7]["Key"]["Id"].Value);
            Assert.AreEqual(DateTimeOffset.MaxValue.Year, ((DateTimeOffset)properties[7]["Value"].Value).Year);
        }

        [TestMethod]
        public void TestResultObjectShouldContainAllPropertiesOnDeserialization()
        {
-            var json = "{\"TestCase\":{\"Properties\":[{\"Key\":{\"Id\":\"TestCase.FullyQualifiedName\",\"Label\":\"FullyQualifiedName\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestClass.sampleTestCase\"},{\"Key\":{\"Id\":\"TestCase.ExecutorUri\",\"Label\":\"Executor Uri\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.Uri\"},\"Value\":\"executor://sampleTestExecutor\"},{\"Key\":{\"Id\":\"TestCase.Source\",\"Label\":\"Source\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleTest.dll\"}]},\"Attachments\":[],\"Messages\":[],\"Properties\":[{\"Key\":{\"Id\":\"TestResult.Outcome\",\"Label\":\"Outcome\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"Microsoft.VisualStudio.TestPlatform.ObjectModel.TestOutcome\"},\"Value\":1},{\"Key\":{\"Id\":\"TestResult.ErrorMessage\",\"Label\":\"Error Message\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleError\"},{\"Key\":{\"Id\":\"TestResult.ErrorStackTrace\",\"Label\":\"Error Stack Trace\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleStackTrace\"},{\"Key\":{\"Id\":\"TestResult.DisplayName\",\"Label\":\"TestResult Display Name\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestResult\"},{\"Key\":{\"Id\":\"TestResult.ComputerName\",\"Label\":\"Computer Name\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleComputerName\"},{\"Key\":{\"Id\":\"TestResult.Duration\",\"Label\":\"Duration\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.TimeSpan\"},\"Value\":\"10675199.02:48:05.4775807\"},{\"Key\":{\"Id\":\"TestResult.StartTime\",\"Label\":\"Start Time\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"0001-01-01T00:00:00+00:00\"},{\"Key\":{\"Id\":\"TestResult.EndTime\",\"Label\":\"End Time\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"9999-12-31T23:59:59.9999999+00:00\"}]}";
+            var json = "{\"TestCase\":{\"Properties\":[{\"Key\":{\"Id\":\"TestCase.FullyQualifiedName\",\"Label\":\"FullyQualifiedName\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestClass.sampleTestCase\"},{\"Key\":{\"Id\":\"TestCase.ExecutorUri\",\"Label\":\"Executor Uri\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.Uri\"},\"Value\":\"executor://sampleTestExecutor\"},{\"Key\":{\"Id\":\"TestCase.Source\",\"Label\":\"Source\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleTest.dll\"}]},\"Attachments\":[],\"Messages\":[],\"Properties\":[{\"Key\":{\"Id\":\"TestResult.Outcome\",\"Label\":\"Outcome\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"Microsoft.VisualStudio.TestPlatform.ObjectModel.TestOutcome\"},\"Value\":1},{\"Key\":{\"Id\":\"TestResult.ErrorMessage\",\"Label\":\"Error Message\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleError\"},{\"Key\":{\"Id\":\"TestResult.ErrorStackTrace\",\"Label\":\"Error Stack Trace\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleStackTrace\"},{\"Key\":{\"Id\":\"TestResult.DisplayName\",\"Label\":\"TestResult Display Name\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestResult\"},{\"Key\":{\"Id\":\"TestResult.ComputerName\",\"Label\":\"Computer Name\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleComputerName\"},{\"Key\":{\"Id\":\"TestResult.Duration\",\"Label\":\"Duration\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.TimeSpan\"},\"Value\":\"10675199.02:48:05.4775807\"},{\"Key\":{\"Id\":\"TestResult.StartTime\",\"Label\":\"Start Time\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"2007-03-10T00:00:00+00:00\"},{\"Key\":{\"Id\":\"TestResult.EndTime\",\"Label\":\"End Time\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"9999-12-31T23:59:59.9999999+00:00\"}]}";


Why is this change required?

Changed the testcase to have realistic value rather than default min value.

codito · 2017-04-04T12:19:42Z

....TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestResultSerializationTests.cs

@@ -90,7 +93,6 @@ public void TestResultObjectShouldSerializeAttachments()
            var result = new TestResult(testCase);
            result.Attachments.Add(new AttachmentSet(new Uri("http://dummyUri"), "sampleAttachment"));
            var expectedJson = "{\"TestCase\":{\"Properties\":[{\"Key\":{\"Id\":\"TestCase.FullyQualifiedName\",\"Label\":\"FullyQualifiedName\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestClass.sampleTestCase\"},{\"Key\":{\"Id\":\"TestCase.ExecutorUri\",\"Label\":\"Executor Uri\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.Uri\"},\"Value\":\"executor://sampleTestExecutor\"},{\"Key\":{\"Id\":\"TestCase.Source\",\"Label\":\"Source\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleTest.dll\"}]},\"Attachments\":[{\"Uri\":\"http://dummyUri\",\"DisplayName\":\"sampleAttachment\",\"Attachments\":[]}],\"Messages\":[],\"Properties\":[]}";
-


Please undo. New line is required between Arrange and Act parts of a test method.

codito · 2017-04-04T12:21:24Z

....TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestResultSerializationTests.cs

+            var result = new TestResult(testCase);
+            result.Attachments.Add(new AttachmentSet(new Uri("http://dummyUri"), "sampleAttachment"));
+            var expectedJson = "{\"TestCase\":{\"Properties\":[{\"Key\":{\"Id\":\"TestCase.FullyQualifiedName\",\"Label\":\"FullyQualifiedName\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.String\"},\"Value\":\"sampleTestClass.sampleTestCase\"},{\"Key\":{\"Id\":\"TestCase.ExecutorUri\",\"Label\":\"Executor Uri\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":1,\"ValueType\":\"System.Uri\"},\"Value\":\"executor://sampleTestExecutor\"},{\"Key\":{\"Id\":\"TestCase.Source\",\"Label\":\"Source\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"sampleTest.dll\"}]},\"Attachments\":[{\"Uri\":\"http://dummyUri\",\"DisplayName\":\"sampleAttachment\",\"Attachments\":[]}],\"Messages\":[],\"Properties\":[]}";
+            var json = Serialize(result);


New line between arrange and act. Fix elsewhere in file.

codito · 2017-04-04T12:23:27Z

src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs

+        /// <param name="messageType">Type of Message to be sent, for instance TestSessionStart</param>
+        /// <param name="payload">payload to be sent</param>
+        /// <param name="version">version to be sent</param>
+        public void SendMessage(string messageType, object payload, int version)


Require tests?

codito · 2017-04-04T12:26:19Z

src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs

+            }
+            else if (message.MessageType == MessageType.ProtocolError)
+            {
+                EqtTrace.Error("TestRequestSender: VersionCheck Failed");


Protocol.Error doesn't specify what's the highest version supported at the other end? How does user find why version check failed?

codito · 2017-04-04T12:26:51Z

src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs

+                var protocolVersion = this.dataSerializer.DeserializePayload<int>(message);
+
+                // TODO: Should we check if this is valid ?
+                this.highestNegotiatedVersion = protocolVersion;


Log this please. What does TODO mean?

codito · 2017-04-04T12:47:54Z

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs

+                // Handling special case for dotnet core projects with older test hosts
+                // Older test hosts are not aware of protocol version check
+                // Hence we should not be sending VersionCheck message to these test hosts
+                bool checkRequired = true;


Can this move out as an static extension method to ITestHostManager?

codito · 2017-04-04T12:49:57Z

src/Microsoft.TestPlatform.CrossPlatEngine/EventHandlers/TestRequestHandler.cs

@@ -212,20 +231,20 @@ public void Close()
        /// <inheritdoc/>
        public void SendTestCases(IEnumerable<TestCase> discoveredTestCases)
        {
-            this.communicationManager.SendMessage(MessageType.TestCasesFound, discoveredTestCases);
+            this.communicationManager.SendMessage(MessageType.TestCasesFound, discoveredTestCases, protocolVersion);


this.protocolVersion

codito · 2017-04-04T12:57:02Z

test/Microsoft.TestPlatform.CommunicationUtilities.UnitTests/TestRequestSenderTests.cs

@@ -277,7 +308,7 @@ public void StartTestRunWithSourcesShouldCallHandleTestRunStatsChange()

            waitHandle.WaitOne();

-            this.mockCommunicationManager.Verify(mc => mc.SendMessage(MessageType.StartTestExecutionWithSources, runCriteria), Times.Once);
+            this.mockCommunicationManager.Verify(mc => mc.SendMessage(MessageType.StartTestExecutionWithSources, runCriteria, this.version), Times.Once);


Better to extract a method VerifySendMessage(messageType, payload) for all repetitions.

codito · 2017-04-04T12:58:17Z

src/Microsoft.TestPlatform.CrossPlatEngine/EventHandlers/TestRequestHandler.cs

+                        // Can only do this after InitializeCommunication because TestHost cannot "Send Log" unless communications are initialized
+                        if (!string.IsNullOrEmpty(EqtTrace.LogFile))
+                        {
+                            this.SendLog(TestMessageLevel.Informational, string.Format("Logging TestHost Diagnostics in file: {0}", EqtTrace.LogFile));


Should this be added to a resource?

codito · 2017-04-04T13:00:33Z

src/Microsoft.TestPlatform.ObjectModel/TestObject.cs

@@ -269,7 +295,7 @@ private void PrivateSetPropertyValue(TestProperty property, object value)
        /// Convert passed in value from TestProperty's specified value type.
        /// </summary>
        /// <returns>Converted object</returns>
-        private static object ConvertPropertyFrom<T>(TestProperty property, CultureInfo culture, object value)
+        internal static object ConvertPropertyFrom<T>(TestProperty property, CultureInfo culture, object value)


Why is this required?

Not required now. Switched back.

codito · 2017-04-04T13:23:15Z

src/Microsoft.TestPlatform.ObjectModel/TestObject.cs

+        /// <summary>
+        /// Set TestProperty's value to the specified value T.
+        /// </summary>
+        protected void SetLocalPropertyValue<T>(TestProperty property, T value)


I am not sure if this is the right thing to do. In protocol V2 too, user will unnecessarily pay the cost of an additional dictionary and hashing several properties in it.

Adding the perf tests.

1. Enable use of new Message type.

064340a

2. Protocol version check between runner and host 3. Object model changes for reducing the verbosity. 4. Serializers for supported protocol versions. 5. Unit tests

singhsarab requested review from codito and smadala March 30, 2017 06:01

msftclas added the cla-not-required label Mar 30, 2017

singhsarab added 6 commits March 30, 2017 12:19

Merge remote-tracking branch 'upstream/master' into Protocolv2Changes.

0507a7b

Code analysis related fixes.

45b237a

Fixed the failing tests.

b6e8238

Fix : SendLog message to be sent post version check.

e2da06d

Fixing the test case filter issue.

dda2b84

Changing the TestCase and TestResult objects, and cleaned up the converters.

Merge remote-tracking branch 'upstream/master' into Protocolv2Changes.

3876bfa

AbhitejJohn reviewed Apr 3, 2017

View reviewed changes

AbhitejJohn reviewed Apr 4, 2017

View reviewed changes

AbhitejJohn approved these changes Apr 4, 2017

View reviewed changes

codito reviewed Apr 4, 2017

View reviewed changes

singhsarab added 3 commits April 6, 2017 17:42

Changes as per comments.

9a0002c

Adding the perf tests.

Merge remote-tracking branch 'upstream/master' into Protocolv2Changes

5a0e4e9

Fixed the tests using ITestRequestSender.CheckVersionWithTestHost.

ec2d332

singhsarab merged commit 208db29 into microsoft:master Apr 6, 2017

		@@ -28,18 +28,29 @@ public sealed class TestRequestSender : ITestRequestSender

		private IDataSerializer dataSerializer;

		// TODO:sasin Change the version to 2

Protocol v2 changes #672

Protocol v2 changes #672

Conversation

singhsarab commented Mar 30, 2017 • edited by codito Loading

msftclas commented Mar 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codito Apr 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

singhsarab Apr 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

singhsarab commented Mar 30, 2017 •

edited by codito

Loading

codito Apr 4, 2017 •

edited

Loading

singhsarab Apr 6, 2017 •

edited

Loading