Sign in using GitHub Enterprise or ADFS Account

[MichaelAndCara]

Request

Not sure if it's already in the works, but will it be possible to sign in using a GitHub enterprise account, which is wired to our AD credentials?

Product and Version [VS/VSCode]: VSCode 1.22.2
OS Version [macOS/Windows]: Windows 10
Live Share Extension Version: 0.3.93
Target Platform or Language [e.g. Node.js]: any

Steps to Reproduce / Scenario:

1. Sign In
2. Choose github

[Chuxel]

@MichaelAndCara Thanks for asking. If your organization uses Azure AD, you can sign into that account using the "Microsoft" path. We support AAD and personal Microsoft accounts. However, we do not support on-prem ADFS or on-prem GitHub. Does that meet your need?

[MichaelAndCara]

Our organization does not use AADs, but Devs do have Microsoft accounts, which we can use.

However, our employees in our IT department are guaranteed to have a "normal" AD account. I figured if we were mentoring anyone (employees interested in becoming developers, interns, etc), it would be convenient to use our GitHub enterprise account that is tied to our "normal" AD accounts.

Thanks @Chuxel

[Chuxel]

@MichaelAndCara Got it. I'll flip this to a feature request given it sounds like in an ideal world you'd be able to use on-prem AD.

[HenryHW]

Really need the on-prem AD feature. Most of the environments I work in don't allow any Azure access.
All Azure access is done on a separate network.

[spkane]

Github Enterprise support would be great.

[peteashworth]

We would love to use this in our organization but require github enterprise support.

[lostintangent]

@spkane @AshworthHub Out of curiosity: would on-prem AD support address your needs? Or would you specifically need GitHub Enterprise authentication?

[peteashworth]

@lostintangent we would need github enterprise.

[spkane]

@lostintangent Github Enterprise support. We are not a Windows shop, so AD support would not help us, but we do use GHE internally.

I would not expect this to be difficult, since as far as I know, it has all the same APIs. They usually just have a different base URL.

[mezafits]

This would be nice to have as an on prem solution, perhaps TFS integration?

[legomushroom]

cc @avanderhoorn

[Garen]

Suggest splitting this into two issues - I'm only interested in local AD support. (Some Github Enterprise users use it with AD, others don't).

[CalPolyRock]

Agree simple ad/ldap is all we need too.
We'll never do github enterprise since we have on prem Atlassian stack.

[Arshia001]

Also need this.

[louisfischer]

Need this also

[MichaelSteinecke]

In our company, we're developing in an completely disconnected environment with On Premise TFS and On Premise AD. So, on-prem ADFS is a must.

[RobFur]

We are also developing in a completely disconnected environment and on-prem ADFS is also a must for us.

[zhaoshouren]

would be interested in an on premise solution for organizations with restricted external network access.

[allendcr]

One more for "totally disconnected environment" - LiveShare would be huge for us but t's currently DOA

[BenBurge]

This feature for Live Share will be used by a lot of DoD contractors and government. Many times we are on offline networks for security reasons. The market for On-Premise is very large with governments.

[dnyazali]

Could anyone share the latest status on this?

[mmodrow]

Could anyone share the latest status on this?

Looks to me like Microsoft is pretty busy ignoring this request to pressure everyone off on-premise solution.

[lalten]

@Chuxel @lostintangent @avanderhoorn is this on any roadmap? I would really love GitHub Enterprise auth.

[jspada200]

Echoing what everyone else is saying. We could really use this but are air gapped so we are unable to meet the microsoft login requirements. Really need another solution for authentication.

[adamdost-0]

Any updates on this?

[matheuskknd]

I'm also interested in this feature. A simple "IP+port" connection option would be enough for now, as we could set up a secure tunnel through many other ways (with any possible authentication method).

[GeorgeWL]

I know it must be possible, as the Github Pull Requests extension, can do it fine

[samibrahmi]

In our company, we're on a disconnected environment with an On Premise AD so I think on-prem ADFS will be a must.

[cadeff01]

Disconnected or public sector azure gov both need this feature. Please implement.

[GeorgeWL]

👍

[rmace001]

👍

[jnorto1986]

Does anyone know if ADFS support has been added yet? Or if support for Gov cloud has been added?

[1oakao1]

I am echoing what everyone else is saying. We could really use this but we are air-gapped so we are unable to meet the Microsoft login requirements. We really need another solution for authentication.

[marcinsmialek]

It's not possible to Live Share on networks with limited connectivity.

Because #1432 got closed as a dupe of this issue:
In such scenarios, we need on-prem relay too, as well as port remapping.

If there are reasons to limit Internet access, one should expect incoming connections and port range restrictions too. The connectivity needs for the relay that you made and deployed in cloud, still apply in other (separated/filtered) networks.

[GeorgeWL]

It's not possible to Live Share on networks with limited connectivity.

Because #1432 got closed as a dupe of this issue: In such scenarios, we need on-prem relay too, as well as port remapping.

If there are reasons to limit Internet access, one should expect incoming connections and port range restrictions too. The connectivity needs for the relay that you made and deployed in cloud, still apply in other (separated/filtered) networks.

i feel like this is a seperate issue, and whoever closed it was wrong to do so

[lalten]

https://github.com/microsoft/vscode-pull-request-github/releases/tag/v0.52.0
includes support for

the VS Code built in GitHub Enterprise authentication provider

Is this something that will help make progress on this issue @avanderhoorn?

[httpete]

This is so sorely needed. We have github enterprise accounts.

[fubaduba]

I would love to understand specific use cases and company profiles that use Live Share with GitHub Enterprise accounts, and with their own AD's. While we consider this issue further, and evaluate how best to support companies that have network restrictions, please shoot an email to: filisha.shah@microsoft.com if you'd like to help us understand your use case better. Thanks!

[lateo-net]

I would love to understand specific use cases and company profiles that use Live Share with GitHub Enterprise accounts, and with their own AD's. While we consider this issue further, and evaluate how best to support companies that have network restrictions, please shoot an email to: filisha.shah@microsoft.com if you'd like to help us understand your use case better. Thanks!

Many of us work in air-gapped networks : No internet access = Just can't use LiveShare as it is today.
But ActiveDirectory is so cool it's almost mandatory so many enterprises use it those networks.
Add the possibility to log-in through AD (or GHEnterprise, why not) and suddenly many of us can enjoy LiveShare.

[derekbekoe]

Unfortunately, we’re not able to prioritize this feature over the other current areas of focus on the team. We understand that this may be disappointing. We appreciate your input and comments on this issue till now.

[GeorgeWL]

👎