Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborator saving removes uncommited whitespace for collaborator cursors when auto format on save #568

Closed
AndreasBackx opened this issue Jun 19, 2018 · 5 comments

Comments

@AndreasBackx
Copy link

Product and Version [VS/VSCode]: 1.24.1
OS Version [macOS/Windows]: Linux
Live Share Extension Version: 0.3.295
Target Platform or Language [e.g. Node.js]: irrelevant

Steps to Reproduce / Scenario:

  1. Start a collaboration session.
  2. Let someone else join the session.
  3. Place your cursor on a different line than the "guest" and indent some.
  4. Tell the other user to save the file, triggering VS Code to remove the whitespace.
  5. The whitespace is removed on the line I was currently working on (when it was empty).

When working with someone and you're starting on a new line and the indentation is suddenly gone because the other user saved the project (out of habit) it's a little bit frustrating.

This also happens to the guest when the host saves.

@AndreasBackx AndreasBackx changed the title Collaborator saving ignores host cursor when removing whitespace Collaborator saving ignores other collaborator cursors when removing whitespace Jun 19, 2018
@grork
Copy link

grork commented Jun 19, 2018

This is when you have the editor.formatOnSave setting set to true, on the host, correct?

@AndreasBackx
Copy link
Author

@grork that is correct. Unsure whether the collaborator had it.

@grork grork changed the title Collaborator saving ignores other collaborator cursors when removing whitespace Collaborator saving removes uncommited whitespace for collaborator cursors when auto format on save Jun 19, 2018
@lostintangent
Copy link
Member

@grork This may be related to #552, which could be caused by “editor.formatOnType”

@bowdenk7
Copy link

bowdenk7 commented Dec 2, 2020

Sounds like yall already have a good grasp on this issue and I see its on the roadmap, but figured I would add my info in case it is helpful. I was trying to teach a friend over LiveShare last night when this issue caused us to abandon our LiveShare session in favor of regular screen share.

Seems like the easy work around is turning off formatting which I'll do tonight when we try again.

liveshareWhitespaceIssue

Relevant settings:
image

Let me know if there is anything else I can provide to help!

@derekbekoe
Copy link
Collaborator

Closing as stale.

@derekbekoe derekbekoe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants