You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does it mean that someone can add a highlight range to the selection? And, if so, could it cause some problems?
Also, we could imagine that the selection is highlighting its ranges internally (so ::selection ~== ::highlight(selection)). I wonder if this could have some interesting implications.
The text was updated successfully, but these errors were encountered:
@Reinmar As mentioned in #69 , we have removed HighlightRange from this API and use a HighlightRangeGroup to apply highlight styling to a group of ranges. Therefore, this shouldn’t be an issue anymore. Please let me know if you disagree.
moving the issue from https://github.com/dlibby-/highlight/issues/14
@Reinmar as FYI
My understanding is that since
HighlightRange
inherits fromRange
, it can be passed toSelection#addRange()
.According to https://www.w3.org/TR/selection-api/#dom-selection-addrange that range is passed there by a reference and it should be updated once the selection changes.
Does it mean that someone can add a highlight range to the selection? And, if so, could it cause some problems?
Also, we could imagine that the selection is highlighting its ranges internally (so
::selection
~==::highlight(selection)
). I wonder if this could have some interesting implications.The text was updated successfully, but these errors were encountered: