Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: Refresh context menu item name inconsistent #4836

Open
Optimierungswerfer opened this issue Sep 25, 2024 · 0 comments
Open

[Problem/Bug]: Refresh context menu item name inconsistent #4836

Optimierungswerfer opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Optimierungswerfer
Copy link

What happened?

We modify the WebView2 default context menu in our application as described here. Among others we also need to remove the "Refresh" menu item. This page specifies that the Name property is "the English label of the menu item in lower camel case". However, there is no menu item with Name "refresh" although the English label is "Refresh". By pure accident we discovered that the actual Name of that menu item is "reload".

This is a minor inconsistency, but might be confusing to others as well. In the end, one could always enumerate all default menu items and their names to reverse engineer their names that way, but that kind of defeats the purpose of the documentation.

I understand that due to compatibility reasons, you probably cannot change the item name to "refresh" and most likely do not want to change the English label either. So the most likely solution is to change the documentation to point out this inconsistency. There might be other default context menu items affected by this as well.

Importance

Low. My app is not very affected, or this only affects development.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

129.0.2792.52

SDK Version

1.0.2792.45

Framework

Other

Operating System

Windows 11

OS Version

22631.4169

Repro steps

In the CoreWebView2ContextMenuRequested event, iterate over the args.MenuItems and find that the "Refresh" labeled menu item has Name "reload" rather than "refresh".

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

Don't know

Last working version (if regression)

No response

@Optimierungswerfer Optimierungswerfer added the bug Something isn't working label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants