fix: Fixed bit-ack offsets

MidLevel · Sep 4, 2019 · 7087ce9 · 7087ce9
1 parent 8a8b0b5
commit 7087ce9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Ruffles/Channeling/Channels/ReliableChannel.cs b/Ruffles/Channeling/Channels/ReliableChannel.cs
@@ -279,9 +279,9 @@ private void SendAck(ushort sequence)
                 }
 
                 // Set the bit fields
-                for (byte i = 0; i < config.MergedAckBytes * 8; i++)
+                for (int i = 0; i < config.MergedAckBytes * 8; i++)
                 {
-                    ackMemory.Buffer[(i / 8)] |= (byte)(((SequencingUtils.Distance(((ushort)(sequence - (i + 1))), _incomingLowestAckedSequence, sizeof(ushort)) <= 0 || _incomingAckedPackets.Contains(((ushort)(sequence - (i + 1))))) ? 1 : 0) << (7 - (i % 8)));
+                    ackMemory.Buffer[4 + (i / 8)] |= (byte)(((SequencingUtils.Distance(((ushort)(sequence - (i + 1))), _incomingLowestAckedSequence, sizeof(ushort)) <= 0 || _incomingAckedPackets.Contains(((ushort)(sequence - (i + 1))))) ? 1 : 0) << (7 - (i % 8)));
                 }
             }
 

diff --git a/Ruffles/Channeling/Channels/ReliableSequencedChannel.cs b/Ruffles/Channeling/Channels/ReliableSequencedChannel.cs
@@ -288,9 +288,9 @@ private void SendAck(ushort sequence)
                 }
 
                 // Set the bit fields
-                for (byte i = 0; i < config.MergedAckBytes * 8; i++)
+                for (int i = 0; i < config.MergedAckBytes * 8; i++)
                 {
-                    ackMemory.Buffer[(i / 8)] |= (byte)(((SequencingUtils.Distance(((ushort)(sequence - (i + 1))), _incomingLowestAckedSequence, sizeof(ushort)) <= 0 || _receiveSequencer[((ushort)(sequence - (i + 1)))].Alive) ? 1 : 0) << (7 - (i % 8)));
+                    ackMemory.Buffer[4 + (i / 8)] |= (byte)(((SequencingUtils.Distance(((ushort)(sequence - (i + 1))), _incomingLowestAckedSequence, sizeof(ushort)) <= 0 || _receiveSequencer[((ushort)(sequence - (i + 1)))].Alive) ? 1 : 0) << (7 - (i % 8)));
                 }
             }