fix(security): Fixed data leak in memory manager by resetting memory …

…before being reused
MidLevel · Sep 10, 2019 · 9733543 · 9733543
1 parent 1e48aa3
commit 9733543
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/Ruffles/Memory/MemoryManager.cs b/Ruffles/Memory/MemoryManager.cs
@@ -118,6 +118,11 @@ internal HeapMemory AllocHeapMemory(uint size)
                 }
 
                 memory = new HeapMemory(allocSize);
+            }
+            else
+            {
+                // If we got one from the pool, we need to clear it
+                Array.Clear(memory.Buffer, 0, size);
             }
 
             memory.EnsureSize(allocSize);