Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X64] [MichalPetryka] Importer forward substitution #245

Open
MihuBot opened this issue Feb 13, 2024 · 1 comment
Open

[X64] [MichalPetryka] Importer forward substitution #245

MihuBot opened this issue Feb 13, 2024 · 1 comment

Comments

@MihuBot
Copy link
Owner

MihuBot commented Feb 13, 2024

Build completed in 2 hours 14 minutes.
dotnet/runtime#98380

CoreLib diffs

Found 1 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 6810019
Total bytes of diff: 6810019
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 55982 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 260 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 38240968
Total bytes of diff: 38239825
Total bytes of delta: -1143 (-0.00 % of base)
Total relative delta: -6.12
    diff is an improvement.
    relative diff is an improvement.


Total byte diff includes 0 bytes from reconciling methods
	Base had    1 unique methods,      169 unique bytes
	Diff had    1 unique methods,      169 unique bytes

Top file improvements (bytes):
        -602 : System.ComponentModel.TypeConverter.dasm (-0.20 % of base)
        -541 : System.ComponentModel.Composition.dasm (-0.12 % of base)

2 total files with Code Size differences (2 improved, 0 regressed), 254 unchanged.

Top method regressions (bytes):
         169 (Infinity of base) : System.Net.Sockets.dasm - 

Top method improvements (bytes):
        -169 (-100.00 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(long,System.Net.Sockets.SocketAsyncContext,byref,byref):ubyte (FullOpts) (1 base, 0 diff methods)
        -100 (-4.69 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[System.Numerics.Vector`1[float]](System.Collections.Generic.IDictionary`2[System.String,System.Object]):System.Numerics.Vector`1[float] (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[double]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[int]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[long]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[short]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[ubyte]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -89 (-4.27 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[double](System.Collections.Generic.IDictionary`2[System.String,System.Object]):double (FullOpts)
         -89 (-4.27 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[short](System.Collections.Generic.IDictionary`2[System.String,System.Object]):short (FullOpts)
         -88 (-4.23 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[long](System.Collections.Generic.IDictionary`2[System.String,System.Object]):long (FullOpts)
         -88 (-4.23 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[ubyte](System.Collections.Generic.IDictionary`2[System.String,System.Object]):ubyte (FullOpts)
         -87 (-4.19 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[int](System.Collections.Generic.IDictionary`2[System.String,System.Object]):int (FullOpts)
         -49 (-38.89 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.__Canon]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -39 (-38.61 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Nullable`1[int]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -39 (-38.61 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Numerics.Vector`1[float]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)

Top method regressions (percentages):
         169 (Infinity of base) : System.Net.Sockets.dasm - 

Top method improvements (percentages):
        -169 (-100.00 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(long,System.Net.Sockets.SocketAsyncContext,byref,byref):ubyte (FullOpts) (1 base, 0 diff methods)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[double]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[int]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[long]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[short]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -95 (-94.06 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[ubyte]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -49 (-38.89 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.__Canon]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -39 (-38.61 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Nullable`1[int]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
         -39 (-38.61 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Numerics.Vector`1[float]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts)
        -100 (-4.69 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[System.Numerics.Vector`1[float]](System.Collections.Generic.IDictionary`2[System.String,System.Object]):System.Numerics.Vector`1[float] (FullOpts)
         -89 (-4.27 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[double](System.Collections.Generic.IDictionary`2[System.String,System.Object]):double (FullOpts)
         -89 (-4.27 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[short](System.Collections.Generic.IDictionary`2[System.String,System.Object]):short (FullOpts)
         -88 (-4.23 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[long](System.Collections.Generic.IDictionary`2[System.String,System.Object]):long (FullOpts)
         -88 (-4.23 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[ubyte](System.Collections.Generic.IDictionary`2[System.String,System.Object]):ubyte (FullOpts)
         -87 (-4.19 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.MetadataViewProvider:GetMetadataView[int](System.Collections.Generic.IDictionary`2[System.String,System.Object]):int (FullOpts)

16 total methods with Code Size differences (15 improved, 1 regressed), 238856 unchanged.

--------------------------------------------------------------------------------

Artifacts:

@MihuBot
Copy link
Owner Author

MihuBot commented Feb 13, 2024

@MichalPetryka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant