Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use episode updated event to run renamer #31

Open
Terrails opened this issue Jan 31, 2024 · 3 comments
Open

Use episode updated event to run renamer #31

Terrails opened this issue Jan 31, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Terrails
Copy link

Currently, the renamer only runs on import and thats it. Due to that episodes with a title "Episode X" are not renamed to their actual name when/if it is eventually updated. It would be a nice addition to add an option to run the renamer whenever episode info is updated.

@Mik1ll
Copy link
Owner

Mik1ll commented Feb 1, 2024

TODO List/Blocking issues:

  • Task: Determine whether to use IPlugin interface and DI to get the IShokoEventHandler or use reflection and grab the singleton instance ShokoEventHandler.Instance
  • Task: As this feature would be opt in, and must be loaded on startup, a rename script cannot be used to configure this. A new configuration option must be created
    • Look into ISettingsProvider or creating a new config file
  • Blocking: OnSeriesUpdated and OnEpisodeUpdated do not seem to be invoked anywhere within Shoko
  • Blocking: IAnime and IEpisode do not provide Local Video Ids, there is no API endpoint for renaming files related to an anime or episode
    • Potential workaround: Reflection on repositories to query the local files

@Mik1ll Mik1ll self-assigned this Feb 1, 2024
@Mik1ll Mik1ll added the enhancement New feature or request label Feb 1, 2024
@Mik1ll
Copy link
Owner

Mik1ll commented Feb 1, 2024

@Terrails
Copy link
Author

The latest Shoko daily seems to run the renamer on this event now, so there should be no need to implement this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants